Skip to content

Commit 76bcf9c

Browse files
committed
[#1529] Send status codes, run validator
1 parent 766a160 commit 76bcf9c

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

server/controllers/project.controller.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,15 @@ export function updateProject(req, res) {
3030
$set: req.body
3131
},
3232
{
33-
new: true
33+
new: true,
34+
runValidators: true
3435
}
3536
)
3637
.populate('user', 'username')
3738
.exec((updateProjectErr, updatedProject) => {
3839
if (updateProjectErr) {
3940
console.log(updateProjectErr);
40-
res.json({ success: false });
41+
res.status(400).json({ success: false });
4142
return;
4243
}
4344
if (req.body.files && updatedProject.files.length !== req.body.files.length) {
@@ -50,7 +51,7 @@ export function updateProject(req, res) {
5051
updatedProject.save((innerErr, savedProject) => {
5152
if (innerErr) {
5253
console.log(innerErr);
53-
res.json({ success: false });
54+
res.status(400).json({ success: false });
5455
return;
5556
}
5657
res.json(savedProject);

server/controllers/project.controller/createProject.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,8 @@ export default function createProject(req, res) {
88

99
projectValues = Object.assign(projectValues, req.body);
1010

11-
// TODO: Error handling to match spec
1211
function sendFailure() {
13-
res.status(422).json({ success: false });
12+
res.status(400).json({ success: false });
1413
}
1514

1615
function populateUserData(newProject) {

server/models/project.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ fileSchema.set('toJSON', {
2929

3030
const projectSchema = new Schema(
3131
{
32-
name: { type: String, default: "Hello p5.js, it's the server", maxlength: 256 },
32+
name: { type: String, default: "Hello p5.js, it's the server", maxlength: 128 },
3333
user: { type: Schema.Types.ObjectId, ref: 'User' },
3434
serveSecure: { type: Boolean, default: false },
3535
files: { type: [fileSchema] },

0 commit comments

Comments
 (0)