Skip to content

Commit 5b12572

Browse files
committed
🔀 merge
2 parents d667b4b + 778aa4d commit 5b12572

File tree

5 files changed

+12
-9
lines changed

5 files changed

+12
-9
lines changed

client/components/mobile/FloatingNav.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import Button from '../../common/Button';
66
import IconButton from './IconButton';
77

88
const FloatingContainer = styled.div`
9-
position: absolute;
9+
position: fixed;
1010
right: ${remSize(16)};
1111
top: ${remSize(80)};
1212

client/components/mobile/Sidebar.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ const SidebarWrapper = styled.div`
1212
height: 100%;
1313
width: ${remSize(180)};
1414
15-
position: absolute;
15+
position: fixed;
1616
z-index: 2;
1717
left: 0;
1818

client/components/useAsModal.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import styled from 'styled-components';
33
import { useModalBehavior } from '../utils/custom-hooks';
44

55
const BackgroundOverlay = styled.div`
6-
position: absolute;
6+
position: fixed;
77
z-index: 2;
88
width: 100% !important;
99
height: 100% !important;

client/modules/App/App.jsx

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,9 @@ class App extends React.Component {
1818

1919
componentWillReceiveProps(nextProps) {
2020
const locationWillChange = nextProps.location !== this.props.location;
21-
const shouldSkipRemembering = nextProps.location.state && nextProps.location.state.skipSavingPath === true;
21+
const shouldSkipRemembering =
22+
nextProps.location.state &&
23+
nextProps.location.state.skipSavingPath === true;
2224

2325
if (locationWillChange && !shouldSkipRemembering) {
2426
this.props.setPreviousPath(this.props.location.pathname);
@@ -34,9 +36,10 @@ class App extends React.Component {
3436
render() {
3537
return (
3638
<div className="app">
37-
<div style={{ display: 'none' }}>
38-
{this.state.isMounted && !window.devToolsExtension && getConfig('NODE_ENV') === 'development' && <DevTools />}
39-
</div>
39+
{false &&
40+
this.state.isMounted &&
41+
!window.devToolsExtension &&
42+
getConfig('NODE_ENV') === 'development' && <DevTools />}
4043
{this.props.children}
4144
</div>
4245
);
@@ -57,7 +60,7 @@ App.propTypes = {
5760

5861
App.defaultProps = {
5962
children: null,
60-
theme: 'light'
63+
theme: 'light',
6164
};
6265

6366
const mapStateToProps = state => ({

client/utils/custom-hooks.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export const useModalBehavior = (hideOverlay) => {
2828

2929

3030
const handleClickOutside = ({ target }) => {
31-
if (ref && ref.current && !ref.current.contains(target)) {
31+
if (ref && ref.current && !(ref.current.contains && ref.current.contains(target))) {
3232
hide();
3333
}
3434
};

0 commit comments

Comments
 (0)