Skip to content

Commit 4baa20e

Browse files
committed
Merge branch 'release-2.1.3' into develop
2 parents d8c4ca6 + e2be5ad commit 4baa20e

File tree

5 files changed

+16
-7
lines changed

5 files changed

+16
-7
lines changed

.github/workflows/deploy.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ name: Deploy to production
22
on:
33
workflow_run:
44
workflows: ["Test"]
5-
branches:
6-
- release
5+
tags:
6+
- '*'
77
types:
88
- completed
99
env:

client/modules/IDE/pages/FullView.jsx

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,21 @@ import RootPage from '../../../components/RootPage';
1717
function FullView(props) {
1818
const dispatch = useDispatch();
1919
const project = useSelector((state) => state.project);
20+
const [isRendered, setIsRendered] = useState(false);
2021

2122
useEffect(() => {
2223
dispatch(getProject(props.params.project_id, props.params.username));
2324
}, []);
2425

26+
useEffect(() => {
27+
// if (isRendered) prevents startSketch() from being called twice
28+
// this calls startSketch if REGISTER happens before sketch is fetched
29+
if (isRendered) {
30+
dispatch(startSketch());
31+
}
32+
}, [project.id]);
33+
2534
// send register event until iframe is loaded and sends a message back.
26-
const [isRendered, setIsRendered] = useState(false);
2735
const clearInterval = useInterval(() => {
2836
dispatchMessage({ type: MessageTypes.REGISTER });
2937
}, 100);

client/modules/User/pages/CollectionView.jsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import { connect } from 'react-redux';
44
import { withTranslation } from 'react-i18next';
55

66
import Nav from '../../../components/Nav';
7+
import RootPage from '../../../components/RootPage';
78

89
import CollectionCreate from '../components/CollectionCreate';
910
import Collection from '../components/Collection';
@@ -57,11 +58,11 @@ class CollectionView extends React.Component {
5758

5859
render() {
5960
return (
60-
<div className="dashboard">
61+
<RootPage>
6162
<Nav layout="dashboard" />
6263

6364
{this.renderContent()}
64-
</div>
65+
</RootPage>
6566
);
6667
}
6768
}

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "p5.js-web-editor",
3-
"version": "2.1.2",
3+
"version": "2.1.3",
44
"description": "The web editor for p5.js.",
55
"scripts": {
66
"clean": "rimraf dist",

0 commit comments

Comments
 (0)