Skip to content

Commit 6428431

Browse files
Remove the Alpine argon2 library fix
The fix has been patched upstream in Alpine and upcoming PHP 7.4.0alpha2.
1 parent 5964ca5 commit 6428431

File tree

7 files changed

+0
-21
lines changed

7 files changed

+0
-21
lines changed

7.4-rc/alpine3.10/cli/Dockerfile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -113,9 +113,6 @@ RUN set -eux; \
113113
export CFLAGS="$PHP_CFLAGS" \
114114
CPPFLAGS="$PHP_CPPFLAGS" \
115115
LDFLAGS="$PHP_LDFLAGS" \
116-
# fix ARGON2 detection for 7.4-alpha1 https://github.com/docker-library/php/pull/840#pullrequestreview-249660894
117-
ARGON2_LIBS="-largon2" \
118-
ARGON2_CFLAGS="-I/usr/include" \
119116
; \
120117
docker-php-source extract; \
121118
cd /usr/src/php; \

7.4-rc/alpine3.10/fpm/Dockerfile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -114,9 +114,6 @@ RUN set -eux; \
114114
export CFLAGS="$PHP_CFLAGS" \
115115
CPPFLAGS="$PHP_CPPFLAGS" \
116116
LDFLAGS="$PHP_LDFLAGS" \
117-
# fix ARGON2 detection for 7.4-alpha1 https://github.com/docker-library/php/pull/840#pullrequestreview-249660894
118-
ARGON2_LIBS="-largon2" \
119-
ARGON2_CFLAGS="-I/usr/include" \
120117
; \
121118
docker-php-source extract; \
122119
cd /usr/src/php; \

7.4-rc/alpine3.10/zts/Dockerfile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -114,9 +114,6 @@ RUN set -eux; \
114114
export CFLAGS="$PHP_CFLAGS" \
115115
CPPFLAGS="$PHP_CPPFLAGS" \
116116
LDFLAGS="$PHP_LDFLAGS" \
117-
# fix ARGON2 detection for 7.4-alpha1 https://github.com/docker-library/php/pull/840#pullrequestreview-249660894
118-
ARGON2_LIBS="-largon2" \
119-
ARGON2_CFLAGS="-I/usr/include" \
120117
; \
121118
docker-php-source extract; \
122119
cd /usr/src/php; \

7.4-rc/alpine3.9/cli/Dockerfile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -113,9 +113,6 @@ RUN set -eux; \
113113
export CFLAGS="$PHP_CFLAGS" \
114114
CPPFLAGS="$PHP_CPPFLAGS" \
115115
LDFLAGS="$PHP_LDFLAGS" \
116-
# fix ARGON2 detection for 7.4-alpha1 https://github.com/docker-library/php/pull/840#pullrequestreview-249660894
117-
ARGON2_LIBS="-largon2" \
118-
ARGON2_CFLAGS="-I/usr/include" \
119116
; \
120117
docker-php-source extract; \
121118
cd /usr/src/php; \

7.4-rc/alpine3.9/fpm/Dockerfile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -114,9 +114,6 @@ RUN set -eux; \
114114
export CFLAGS="$PHP_CFLAGS" \
115115
CPPFLAGS="$PHP_CPPFLAGS" \
116116
LDFLAGS="$PHP_LDFLAGS" \
117-
# fix ARGON2 detection for 7.4-alpha1 https://github.com/docker-library/php/pull/840#pullrequestreview-249660894
118-
ARGON2_LIBS="-largon2" \
119-
ARGON2_CFLAGS="-I/usr/include" \
120117
; \
121118
docker-php-source extract; \
122119
cd /usr/src/php; \

7.4-rc/alpine3.9/zts/Dockerfile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -114,9 +114,6 @@ RUN set -eux; \
114114
export CFLAGS="$PHP_CFLAGS" \
115115
CPPFLAGS="$PHP_CPPFLAGS" \
116116
LDFLAGS="$PHP_LDFLAGS" \
117-
# fix ARGON2 detection for 7.4-alpha1 https://github.com/docker-library/php/pull/840#pullrequestreview-249660894
118-
ARGON2_LIBS="-largon2" \
119-
ARGON2_CFLAGS="-I/usr/include" \
120117
; \
121118
docker-php-source extract; \
122119
cd /usr/src/php; \

Dockerfile-alpine.template

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -107,9 +107,6 @@ RUN set -eux; \
107107
export CFLAGS="$PHP_CFLAGS" \
108108
CPPFLAGS="$PHP_CPPFLAGS" \
109109
LDFLAGS="$PHP_LDFLAGS" \
110-
# fix ARGON2 detection for 7.4-alpha1 https://github.com/docker-library/php/pull/840#pullrequestreview-249660894
111-
ARGON2_LIBS="-largon2" \
112-
ARGON2_CFLAGS="-I/usr/include" \
113110
; \
114111
docker-php-source extract; \
115112
cd /usr/src/php; \

0 commit comments

Comments
 (0)