feat: added reverse sorting to commitfest form

Author: destrex271

media/commitfest/js/commitfest.js

@@ -257,12 +257,19 @@ function flagCommitted(committer) {
 }
 
 function sortpatches(sortby) {
-    if ($("#id_sortkey").val() === sortby) {
-        $("#id_sortkey").val(0);
-    } else {
-        $("#id_sortkey").val(sortby);
-    }
-    $("#filterform").submit();
+   if ($('#id_sortkey').val() == sortby) {
+      if($('#id_sortorder').val() == 1){
+        $('#id_sortkey').val(0);
+        $('#id_sortorder').val(0); // reset order
+      }else if($('#id_sortorder').val() == -1){
+        $('#id_sortkey').val(sortby);
+        $('#id_sortorder').val(1); // ascending order -> oldest first
+      }
+   } else {
+      $('#id_sortkey').val(sortby);
+      $('#id_sortorder').val(-1); // descending order -> latest first
+   }
+   $('#filterform').submit();
 
     return false;
 }

pgcommitfest/commitfest/forms.py

@@ -17,11 +17,13 @@ class CommitFestFilterForm(forms.Form):
     author = forms.ChoiceField(required=False)
     reviewer = forms.ChoiceField(required=False)
     sortkey = forms.IntegerField(required=False)
+    sortorder = forms.IntegerField(required=False) # 0 -> no order, 1 -> asc, -1 -> desc
 
     def __init__(self, cf, *args, **kwargs):
         super(CommitFestFilterForm, self).__init__(*args, **kwargs)
 
         self.fields["sortkey"].widget = forms.HiddenInput()
+        self.fields["sortorder"].widget = forms.HiddenInput()
 
         c = [(-1, "* All")] + list(PatchOnCommitFest._STATUS_CHOICES)
         self.fields["status"] = forms.ChoiceField(choices=c, required=False)

pgcommitfest/commitfest/views.py

@@ -233,6 +233,7 @@ def commitfest(request, cfid):
     has_filter = len(whereclauses) > 0
 
     # Figure out custom ordering
+
     if request.GET.get("sortkey", "") != "":
         try:
             sortkey = int(request.GET["sortkey"])
@@ -260,6 +261,12 @@ def commitfest(request, cfid):
         orderby_str = "topic, created"
         sortkey = 0
 
+    sortorder = int(request.GET.get("sortorder", "0"))
+    if sortorder == 1:
+        orderby_str += " ASC"
+    elif sortorder == -1:
+        orderby_str += " DESC"
+
     if not has_filter and sortkey == 0 and request.GET:
         # Redirect to get rid of the ugly url
         return HttpResponseRedirect("/%s/" % cf.id)
@@ -346,6 +353,7 @@ def commitfest(request, cfid):
             "title": cf.title,
             "grouping": sortkey == 0,
             "sortkey": sortkey,
+            "sortorder": sortorder,
             "openpatchids": [p["id"] for p in patches if p["is_open"]],
             "header_activity": "Activity log",
             "header_activity_link": "activity/",