Skip to content

Commit e1a2da0

Browse files
committed
start using custom config visibility calculation in modifyPlotProps throughout
1 parent 6f23e4b commit e1a2da0

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

src/components/fields/derived.js

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,13 @@ import Info from './Info';
1111
import {UnconnectedColorPicker} from './ColorPicker';
1212
import {UnconnectedTextEditor} from './TextEditor';
1313
import {UnconnectedVisibilitySelect} from './VisibilitySelect';
14-
import {connectToContainer, getAllAxes, getAxisTitle, axisIdToAxisName} from 'lib';
14+
import {
15+
connectToContainer,
16+
getAllAxes,
17+
getAxisTitle,
18+
axisIdToAxisName,
19+
isValidCustomConfigObject,
20+
} from 'lib';
1521

1622
export const AxisAnchorDropdown = connectToContainer(UnconnectedDropdown, {
1723
modifyPlotProps: (props, context, plotProps) => {
@@ -707,7 +713,9 @@ export const HovermodeDropdown = connectToContainer(UnconnectedVisibilitySelect,
707713

708714
export const HoverColor = connectToContainer(UnconnectedColorPicker, {
709715
modifyPlotProps: (props, context, plotProps) => {
710-
plotProps.isVisible = Boolean(context.fullLayout.hovermode);
716+
plotProps.isVisible = isValidCustomConfigObject(context.customConfig)
717+
? plotProps.isVisible
718+
: Boolean(context.fullLayout.hovermode);
711719
return plotProps;
712720
},
713721
});

0 commit comments

Comments
 (0)