Skip to content

Commit 240b73d

Browse files
last tweak
1 parent cbe3fd2 commit 240b73d

File tree

6 files changed

+13
-11
lines changed

6 files changed

+13
-11
lines changed

src/components/containers/AnnotationAccordion.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ class AnnotationAccordion extends Component {
2222
<AnnotationFold
2323
key={i}
2424
annotationIndex={i}
25-
name={getParsedTemplateString(ann.text, meta)}
25+
name={getParsedTemplateString(ann.text, {meta})}
2626
canDelete={canAdd}
2727
>
2828
{children}

src/components/containers/RangeSelectorAccordion.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class RangeSelectorAccordion extends Component {
3333
<RangeSelectorFold
3434
key={i}
3535
rangeselectorIndex={i}
36-
name={getParsedTemplateString(btn.label, meta)}
36+
name={getParsedTemplateString(btn.label, {meta})}
3737
canDelete={true}
3838
>
3939
{children}

src/components/fields/AxesCreator.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -134,10 +134,9 @@ class UnconnectedAxesCreator extends Component {
134134

135135
function getOptions(axisType) {
136136
return fullLayout._subplots[axisType].map(axisId => ({
137-
label: getParsedTemplateString(
138-
getAxisTitle(fullLayout[axisIdToAxisName(axisId)]),
139-
fullLayout.meta
140-
),
137+
label: getParsedTemplateString(getAxisTitle(fullLayout[axisIdToAxisName(axisId)]), {
138+
meta: fullLayout.meta,
139+
}),
141140
value: axisId,
142141
}));
143142
}

src/components/fields/AxesSelector.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import PropTypes from 'prop-types';
33
import Dropdown from '../widgets/Dropdown';
44
import RadioBlocks from '../widgets/RadioBlocks';
55
import React, {Component} from 'react';
6+
import {getParsedTemplateString} from 'lib';
67

78
class AxesSelector extends Component {
89
constructor(props, context) {
@@ -30,7 +31,9 @@ class AxesSelector extends Component {
3031
option.value === 'allaxes'
3132
? option
3233
: {
33-
label: option.title,
34+
label: getParsedTemplateString(option.title, {
35+
meta: fullLayout.meta,
36+
}),
3437
value: option.value,
3538
}
3639
)

src/lib/connectTraceToPlot.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ export default function connectTraceToPlot(WrappedComponent) {
7171

7272
if (trace && fullTrace) {
7373
this.icon = renderTraceIcon(plotlyTraceToCustomTrace(trace));
74-
this.name = getParsedTemplateString(fullTrace.name, fullTrace.meta);
74+
this.name = getParsedTemplateString(fullTrace.name, {meta: fullTrace.meta});
7575
}
7676
}
7777

src/lib/index.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -203,11 +203,11 @@ function getFullTrace(props, context) {
203203
return fullTrace;
204204
}
205205

206-
function getParsedTemplateString(originalString, meta) {
206+
function getParsedTemplateString(originalString, context) {
207207
let text = originalString;
208208

209-
if (originalString && meta && (meta.length || Object.keys(meta).length)) {
210-
text = templateString(originalString, {meta});
209+
if (originalString && context) {
210+
text = templateString(originalString, context);
211211
}
212212

213213
return text === '' && originalString ? originalString : text;

0 commit comments

Comments
 (0)