Skip to content

Commit e2a4c55

Browse files
PR feedback
1 parent 584d1ef commit e2a4c55

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

contributing.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -306,6 +306,10 @@ And, you'll need the credentials file `~/.pypirc`. Request access from
306306
(plotly_dev) $ twine upload dist/plotly-X.Y.Zrc1*
307307
```
308308

309+
Note: this will intentionally fail if your current git tree is dirty, because we want the tag
310+
to reflect what is being released, and the version number comes from the tag and the dirty-state.
311+
312+
309313
### Publish release candidate of `plotlywidget` and `jupyterlab-plotly` to NPM
310314
Now, publish the release candidate of the `plotlywidget` NPM package.
311315

@@ -413,6 +417,9 @@ Publish the final version to PyPI
413417
(plotly_dev) $ twine upload dist/plotly-X.Y.Z*
414418
```
415419

420+
Note: this will intentionally fail if your current git tree is dirty, because we want the tag
421+
to reflect what is being released, and the version number comes from the tag and the dirty-state.
422+
416423
After it has uploaded, move to another environment and double+triple check that you are able to upgrade ok:
417424
```bash
418425
$ pip install plotly --upgrade

0 commit comments

Comments
 (0)