Skip to content

Commit 84fc4c4

Browse files
committed
stashing some changes
1 parent a87a07b commit 84fc4c4

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

plotly/tests/test_optional/test_figure_factory.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -735,8 +735,11 @@ def test_scatter_plot_matrix_kwargs(self):
735735
'title': 'Numbers'}}
736736
}
737737

738-
self.assert_dict_equal(test_scatter_plot_matrix['layout'],
739-
exp_scatter_plot_matrix['layout'])
740-
741738
self.assert_dict_equal(test_scatter_plot_matrix['data'][0],
742739
exp_scatter_plot_matrix['data'][0])
740+
741+
self.assert_dict_equal(test_scatter_plot_matrix['data'][1],
742+
exp_scatter_plot_matrix['data'][1])
743+
744+
self.assert_dict_equal(test_scatter_plot_matrix['layout'],
745+
exp_scatter_plot_matrix['layout'])

plotly/tools.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1762,15 +1762,13 @@ def _scatterplot_theme(dataframe, headers, diag, size, height, width,
17621762
for listx in dataframe:
17631763
# create a dictionary for index_vals
17641764
unique_index_vals = {}
1765-
unique_index_vals_list = []
17661765
for name in index_vals:
17671766
if name not in unique_index_vals:
17681767
unique_index_vals[name] = []
1769-
unique_index_vals_list.append(name)
17701768

17711769
c_indx = 0 # color index
17721770
# Fill all the rest of the names into the dictionary
1773-
for name in unique_index_vals_list:
1771+
for name in sorted(unique_index_vals.keys()):
17741772
new_listx = []
17751773
new_listy = []
17761774
for j in range(len(index_vals)):
@@ -1871,7 +1869,7 @@ def _scatterplot_theme(dataframe, headers, diag, size, height, width,
18711869
indices = range(1, dim + 1)
18721870
for y_index in indices:
18731871
for x_index in indices:
1874-
for name in trace_list[trace_index]:
1872+
for name in sorted(trace_list[trace_index].keys()):
18751873
fig.append_trace(
18761874
trace_list[trace_index][name],
18771875
y_index,

0 commit comments

Comments
 (0)