Merge pull request #3016 from plotly/jlab3

nicolaskruchten · web-flow · commit 3a6d2b198dd4 · 2021-01-11T14:07:25.000-05:00
support JupyterLab 3 in extensions
diff --git a/packages/javascript/jupyterlab-plotly/package.json b/packages/javascript/jupyterlab-plotly/package.json
@@ -33,7 +33,7 @@
   "dependencies": {
     "plotly.js": "^1.58.2",
     "@types/plotly.js": "1.44.28",
-    "@jupyterlab/rendermime-interfaces": "^1.3.0 || ^2.0.0",
+    "@jupyterlab/rendermime-interfaces": "^1.3.0 || ^2.0.0 || ^3.0.0",
     "@lumino/messaging": "^1.2.3",
     "@lumino/widgets": "^1.8.1",
     "lodash": "^4.17.4"
diff --git a/packages/javascript/plotlywidget/package.json b/packages/javascript/plotlywidget/package.json
@@ -38,6 +38,12 @@
     "lodash": "^4.17.4"
   },
   "jupyterlab": {
-    "extension": "src/jupyterlab-plugin.js"
+    "extension": "src/jupyterlab-plugin.js",
+    "sharedPackages": {
+      "@jupyter-widgets/base": {
+        "bundled": false,
+        "singleton": true
+      }
+    }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -38,6 +38,12 @@`
`38`	`38`	`"lodash": "^4.17.4"`
`39`	`39`	`},`
`40`	`40`	`"jupyterlab": {`
`41`		`- "extension": "src/jupyterlab-plugin.js"`
	`41`	`+ "extension": "src/jupyterlab-plugin.js",`
	`42`	`+ "sharedPackages": {`
	`43`	`+ "@jupyter-widgets/base": {`
	`44`	`+ "bundled": false,`
	`45`	`+ "singleton": true`
	`46`	`+ }`
	`47`	`+ }`
`42`	`48`	`}`
`43`	`49`	`}`