Skip to content

Commit 22e61fb

Browse files
committed
Prefer use of _repr_mimebundle_ in BaseFigureWidget
1 parent 00c18fd commit 22e61fb

File tree

2 files changed

+8
-11
lines changed

2 files changed

+8
-11
lines changed

packages/python/plotly/plotly/basedatatypes.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -819,18 +819,10 @@ def _repr_mimebundle_(self, include=None, exclude=None, validate=True, **kwargs)
819819

820820
renderer_str = pio.renderers.default
821821
renderers = pio._renderers.renderers
822-
renderer_names = renderers._validate_coerce_renderers(renderer_str)
823-
renderers_list = [renderers[name] for name in renderer_names]
824822
from plotly.io._utils import validate_coerce_fig_to_dict
825-
from plotly.io._renderers import MimetypeRenderer
826823

827824
fig_dict = validate_coerce_fig_to_dict(self, validate)
828-
# Mimetype renderers
829-
bundle = {}
830-
for renderer in renderers_list:
831-
if isinstance(renderer, MimetypeRenderer):
832-
bundle.update(renderer.to_mimebundle(fig_dict))
833-
return bundle
825+
return renderers._build_mime_bundle(fig_dict, renderer_str, **kwargs)
834826

835827
def _ipython_display_(self):
836828
"""

packages/python/plotly/plotly/basewidget.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -733,12 +733,17 @@ def _handler_js2py_pointsCallback(self, change):
733733

734734
# Display
735735
# -------
736+
def _repr_html_(self):
737+
"""
738+
Customize html representation
739+
"""
740+
raise NotImplementedError # Prefer _repr_mimebundle_
741+
736742
def _ipython_display_(self):
737743
"""
738744
Handle rich display of figures in ipython contexts
739745
"""
740-
# Override BaseFigure's display to make sure we display the widget version
741-
widgets.DOMWidget._ipython_display_(self)
746+
raise NotImplementedError # Prefer _repr_mimebundle_
742747

743748
# Callbacks
744749
# ---------

0 commit comments

Comments
 (0)