From 4b4477832164d4a90cb352e4fa1feb2376a94c3e Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi Date: Thu, 8 Aug 2024 17:01:27 -0400 Subject: [PATCH 1/3] skip mapbox comparison for now --- test/image/compare_pixels_test.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/test/image/compare_pixels_test.js b/test/image/compare_pixels_test.js index abfcfa0db23..493993f91f1 100644 --- a/test/image/compare_pixels_test.js +++ b/test/image/compare_pixels_test.js @@ -108,6 +108,11 @@ for(var i = 0; i < allMockList.length; i++) { if(blacklist.indexOf(mockName) !== -1) continue; var isMapbox = mockName.substr(0, 7) === 'mapbox_'; + + // We have to skip mapbox since Aug 2024 + // See https://github.com/plotly/plotly.js/issues/7075 + if(isMapbox) continue; + var isOtherFlaky = [ // list flaky mocks other than mapbox: 'map_density0-legend', From 75ab5f0f52ce3fa2b50385c259c5966080bed21b Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi Date: Thu, 8 Aug 2024 17:17:44 -0400 Subject: [PATCH 2/3] blacklist map_angles which is very flaky --- test/image/compare_pixels_test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/image/compare_pixels_test.js b/test/image/compare_pixels_test.js index 493993f91f1..eb2fd5e7364 100644 --- a/test/image/compare_pixels_test.js +++ b/test/image/compare_pixels_test.js @@ -61,6 +61,7 @@ argv._.forEach(function(pattern) { }); var blacklist = [ + 'map_angles', 'map_stamen-style', 'mapbox_stamen-style', 'mapbox_custom-style', @@ -165,7 +166,6 @@ for(var i = 0; i < allMockList.length; i++) { var threshold = shouldBePixelPerfect ? 0 : [ // more flaky - 'map_angles', 'mapbox_angles', 'mapbox_layers', 'mapbox_custom-style', From 32e3b64853c73708c8008cdea63dbdebb5d3c529 Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi Date: Fri, 9 Aug 2024 10:11:38 -0400 Subject: [PATCH 3/3] skip mapbox custom attribution test on CI for now --- test/jasmine/tests/mapbox_test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/jasmine/tests/mapbox_test.js b/test/jasmine/tests/mapbox_test.js index 25784aa8840..0432710fade 100644 --- a/test/jasmine/tests/mapbox_test.js +++ b/test/jasmine/tests/mapbox_test.js @@ -1610,7 +1610,7 @@ describe('mapbox plots', function() { .then(done, done.fail); }); - it('@gl should be displayed for attributions defined in layers\' sourceattribution', function(done) { + it('@noCI @gl should be displayed for attributions defined in layers\' sourceattribution', function(done) { var mock = require('../../image/mocks/mapbox_layers.json'); var customMock = Lib.extendDeep(mock);