From a41c05d899dfdeab2b7296cc816cc501f5516e70 Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi Date: Wed, 15 Feb 2023 17:32:31 -0500 Subject: [PATCH 1/2] bump plotly d3 to v3.8.1 --- package-lock.json | 14 +++++++------- package.json | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/package-lock.json b/package-lock.json index 537fee8a21c..d09eba47675 100644 --- a/package-lock.json +++ b/package-lock.json @@ -9,7 +9,7 @@ "version": "2.18.1", "license": "MIT", "dependencies": { - "@plotly/d3": "3.8.0", + "@plotly/d3": "3.8.1", "@plotly/d3-sankey": "0.7.2", "@plotly/d3-sankey-circular": "0.33.1", "@turf/area": "^6.4.0", @@ -2160,9 +2160,9 @@ } }, "node_modules/@plotly/d3": { - "version": "3.8.0", - "resolved": "https://registry.npmjs.org/@plotly/d3/-/d3-3.8.0.tgz", - "integrity": "sha512-L10iHgzvw3uSic/nQpYehlNzxUQvImwms5U7S95pJAEhrllzkrdQNy1Mc5DW9ab881Yr4fh300gJztKXWZDfkQ==" + "version": "3.8.1", + "resolved": "https://registry.npmjs.org/@plotly/d3/-/d3-3.8.1.tgz", + "integrity": "sha512-x49ThEu1FRA00kTso4Jdfyf2byaCPLBGmLjAYQz5OzaPyLUhHesX3/Nfv2OHEhynhdy2UB39DLXq6thYe2L2kg==" }, "node_modules/@plotly/d3-sankey": { "version": "0.7.2", @@ -14107,9 +14107,9 @@ } }, "@plotly/d3": { - "version": "3.8.0", - "resolved": "https://registry.npmjs.org/@plotly/d3/-/d3-3.8.0.tgz", - "integrity": "sha512-L10iHgzvw3uSic/nQpYehlNzxUQvImwms5U7S95pJAEhrllzkrdQNy1Mc5DW9ab881Yr4fh300gJztKXWZDfkQ==" + "version": "3.8.1", + "resolved": "https://registry.npmjs.org/@plotly/d3/-/d3-3.8.1.tgz", + "integrity": "sha512-x49ThEu1FRA00kTso4Jdfyf2byaCPLBGmLjAYQz5OzaPyLUhHesX3/Nfv2OHEhynhdy2UB39DLXq6thYe2L2kg==" }, "@plotly/d3-sankey": { "version": "0.7.2", diff --git a/package.json b/package.json index d59ce1b3789..c1fae850cb0 100644 --- a/package.json +++ b/package.json @@ -70,7 +70,7 @@ ] }, "dependencies": { - "@plotly/d3": "3.8.0", + "@plotly/d3": "3.8.1", "@plotly/d3-sankey": "0.7.2", "@plotly/d3-sankey-circular": "0.33.1", "@turf/area": "^6.4.0", From 39f817befc833d33775979e1af14f2dbec55b133 Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi Date: Wed, 15 Feb 2023 17:38:11 -0500 Subject: [PATCH 2/2] test locking issue 6483 --- test/jasmine/bundle_tests/minified_bundle_test.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/jasmine/bundle_tests/minified_bundle_test.js b/test/jasmine/bundle_tests/minified_bundle_test.js index 3915328421f..9c83946a28c 100644 --- a/test/jasmine/bundle_tests/minified_bundle_test.js +++ b/test/jasmine/bundle_tests/minified_bundle_test.js @@ -25,4 +25,8 @@ describe('Test plotly.min.js', function() { Plotly.newPlot(gd, mockSpec[1]).catch(fail).then(done); }, LONG_TIMEOUT_INTERVAL); }); + + it('should not expose d3', function() { + expect(window.d3).not.toBeDefined(); + }); });