From ad0f6de83984ec7d8dfcfa1837d61ea01dab1637 Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi Date: Wed, 15 Feb 2023 13:49:04 -0500 Subject: [PATCH 1/3] bump chrome version from 93 to 110 --- .circleci/config.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index dba2f83dbab..33047b16956 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -56,7 +56,7 @@ jobs: working_directory: ~/plotly.js steps: - browser-tools/install-browser-tools: &browser-versions - chrome-version: 93.0.4577.63 + chrome-version: 110.0.5481.100 install-firefox: false install-geckodriver: false - attach_workspace: @@ -93,7 +93,7 @@ jobs: working_directory: ~/plotly.js steps: - browser-tools/install-browser-tools: &browser-versions - chrome-version: 93.0.4577.63 + chrome-version: 110.0.5481.100 install-firefox: false install-geckodriver: false - attach_workspace: @@ -113,7 +113,7 @@ jobs: working_directory: ~/plotly.js steps: - browser-tools/install-browser-tools: &browser-versions - chrome-version: 93.0.4577.63 + chrome-version: 110.0.5481.100 install-firefox: false install-geckodriver: false - attach_workspace: @@ -132,7 +132,7 @@ jobs: working_directory: ~/plotly.js steps: - browser-tools/install-browser-tools: &browser-versions - chrome-version: 93.0.4577.63 + chrome-version: 110.0.5481.100 install-firefox: false install-geckodriver: false - attach_workspace: @@ -151,7 +151,7 @@ jobs: working_directory: ~/plotly.js steps: - browser-tools/install-browser-tools: &browser-versions - chrome-version: 93.0.4577.63 + chrome-version: 110.0.5481.100 install-firefox: false install-geckodriver: false - attach_workspace: From b516ddde8039462c548783a4bb2b0403353c2ffa Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi Date: Wed, 15 Feb 2023 13:57:56 -0500 Subject: [PATCH 2/3] adjust geo_test --- test/jasmine/tests/geo_test.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/jasmine/tests/geo_test.js b/test/jasmine/tests/geo_test.js index f08a62199e1..12979c6e15d 100644 --- a/test/jasmine/tests/geo_test.js +++ b/test/jasmine/tests/geo_test.js @@ -2759,10 +2759,10 @@ describe('Test geo interactions update marker angles:', function() { }) .then(function() { newPath = getPath(); - expect(newPath).toEqual('M0,0L18.238949513733473,8.206139204003389L19.579067718529352,-4.081679467234269Z'); + expect(newPath).toEqual('M0,0L18.238949470790537,8.206139299448276L19.579067739888885,-4.081679364776507Z'); expect(newPath).not.toEqual(initialPath); - expect(newPath).toEqual('M0,0L18.238949513733473,8.206139204003389L19.579067718529352,-4.081679467234269Z'); + expect(newPath).toEqual('M0,0L18.238949470790537,8.206139299448276L19.579067739888885,-4.081679364776507Z'); expect(initialPath).toEqual('M0,0L-1.5033314641545745,19.94341982983066L10.506227353572104,17.01820163222463Z'); }) .then(done, done.fail); From ac0932a026c0c0b4b8cf2bf9d83edb3d90777fcf Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi Date: Wed, 15 Feb 2023 14:22:03 -0500 Subject: [PATCH 3/3] add noCI flags until we could adjust those tests --- test/jasmine/tests/sankey_test.js | 2 +- test/jasmine/tests/select_test.js | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/test/jasmine/tests/sankey_test.js b/test/jasmine/tests/sankey_test.js index d6f98a51852..3fb1d7188e5 100644 --- a/test/jasmine/tests/sankey_test.js +++ b/test/jasmine/tests/sankey_test.js @@ -771,7 +771,7 @@ describe('sankey tests', function() { .then(done, done.fail); }); - it('should position hover labels correctly', function(done) { + it('@noCI should position hover labels correctly', function(done) { var gd = createGraphDiv(); var mockCopy = Lib.extendDeep({}, mock); diff --git a/test/jasmine/tests/select_test.js b/test/jasmine/tests/select_test.js index 0407e0dca17..7029afc14ff 100644 --- a/test/jasmine/tests/select_test.js +++ b/test/jasmine/tests/select_test.js @@ -2277,7 +2277,7 @@ describe('Test select box and lasso per trace:', function() { }); [false, true].forEach(function(hasCssTransform) { - it('should work for waterfall traces, hasCssTransform: ' + hasCssTransform, function(done) { + it('@noCI should work for waterfall traces, hasCssTransform: ' + hasCssTransform, function(done) { var assertPoints = makeAssertPoints(['curveNumber', 'x', 'y']); var assertSelectedPoints = makeAssertSelectedPoints(); var assertRanges = makeAssertRanges(); @@ -2338,7 +2338,7 @@ describe('Test select box and lasso per trace:', function() { }); [false, true].forEach(function(hasCssTransform) { - it('should work for funnel traces, hasCssTransform: ' + hasCssTransform, function(done) { + it('@noCI should work for funnel traces, hasCssTransform: ' + hasCssTransform, function(done) { var assertPoints = makeAssertPoints(['curveNumber', 'x', 'y']); var assertSelectedPoints = makeAssertSelectedPoints(); var assertRanges = makeAssertRanges(); @@ -2492,7 +2492,7 @@ describe('Test select box and lasso per trace:', function() { }); [false, true].forEach(function(hasCssTransform) { - it('should work for date/category traces, hasCssTransform: ' + hasCssTransform, function(done) { + it('@noCI should work for date/category traces, hasCssTransform: ' + hasCssTransform, function(done) { var assertPoints = makeAssertPoints(['curveNumber', 'x', 'y']); var assertSelectedPoints = makeAssertSelectedPoints();