From f34a9bae288705afb630e0f123f901cd08dbb445 Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi Date: Thu, 2 Feb 2023 11:29:59 -0500 Subject: [PATCH 1/3] fix hover on IE - note getBoundingClientRect on IE has no x and y --- src/components/fx/hover.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/fx/hover.js b/src/components/fx/hover.js index 8e027ad3d6b..3ec8f87db48 100644 --- a/src/components/fx/hover.js +++ b/src/components/fx/hover.js @@ -2124,8 +2124,8 @@ function getBoundingClientRect(gd, node) { var rect = node.getBoundingClientRect(); - var x0 = rect.x; - var y0 = rect.y; + var x0 = rect.left; + var y0 = rect.top; var x1 = x0 + rect.width; var y1 = y0 + rect.height; From eaad4f78376de7d8fc470cac753700c35d9b4d83 Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi Date: Thu, 2 Feb 2023 11:37:14 -0500 Subject: [PATCH 2/3] remove unnecessary checks for dom rects --- src/lib/dom.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/lib/dom.js b/src/lib/dom.js index 6a13e80c188..08c8ee6b20b 100644 --- a/src/lib/dom.js +++ b/src/lib/dom.js @@ -145,8 +145,6 @@ function isTransformableElement(element) { function equalDomRects(a, b) { return ( a && b && - a.x === b.x && - a.y === b.y && a.top === b.top && a.left === b.left && a.right === b.right && From a0c6ec085bb1d99cdc16f74a3ca68164d11e59ab Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi Date: Thu, 2 Feb 2023 11:55:45 -0500 Subject: [PATCH 3/3] log for PR 6466 --- draftlogs/#6466_fix.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 draftlogs/#6466_fix.md diff --git a/draftlogs/#6466_fix.md b/draftlogs/#6466_fix.md new file mode 100644 index 00000000000..3149c102208 --- /dev/null +++ b/draftlogs/#6466_fix.md @@ -0,0 +1 @@ + - Fix hover on IE (regression introduced in 2.5.0) [#6466](https://github.com/plotly/plotly.js/pull/6466)