From b815f314b4ed08ee6af10f5a3fa2d33daf041b83 Mon Sep 17 00:00:00 2001 From: hannahker Date: Mon, 12 Sep 2022 15:17:57 -0400 Subject: [PATCH 1/2] Fix flaky sankey test --- test/jasmine/tests/sankey_test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/jasmine/tests/sankey_test.js b/test/jasmine/tests/sankey_test.js index 9e6f04c67af..6c47afff73e 100644 --- a/test/jasmine/tests/sankey_test.js +++ b/test/jasmine/tests/sankey_test.js @@ -1346,7 +1346,7 @@ describe('sankey tests', function() { nodes = document.getElementsByClassName('sankey-node'); node = nodes.item(nodes.length - 1); // Dragged node is now the last one - return drag({node: node, dpos: move}); + return drag({node: node, dpos: move, timeDelay: arrangement === 'snap' ? 200 : 0}); }) .then(function() { x1 = gd._fullData[0].node.x.slice(); From 606e67c30a49d02bd8b4fbcd82bf0490c37d860e Mon Sep 17 00:00:00 2001 From: hannahker Date: Thu, 15 Sep 2022 13:54:19 -0400 Subject: [PATCH 2/2] Remove from flaky tests --- test/jasmine/tests/sankey_test.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/jasmine/tests/sankey_test.js b/test/jasmine/tests/sankey_test.js index 6c47afff73e..ee503deebe3 100644 --- a/test/jasmine/tests/sankey_test.js +++ b/test/jasmine/tests/sankey_test.js @@ -1318,7 +1318,7 @@ describe('sankey tests', function() { .then(done, done.fail); }); - it('@flaky should persist the position of every nodes after drag in attributes nodes.(x|y)', function(done) { + it('should persist the position of every nodes after drag in attributes nodes.(x|y)', function(done) { mockCopy.data[0].arrangement = arrangement; var move = [50, -50]; var nodes; @@ -1346,7 +1346,7 @@ describe('sankey tests', function() { nodes = document.getElementsByClassName('sankey-node'); node = nodes.item(nodes.length - 1); // Dragged node is now the last one - return drag({node: node, dpos: move, timeDelay: arrangement === 'snap' ? 200 : 0}); + return drag({node: node, dpos: move, timeDelay: arrangement === 'snap' ? 200 : 0}); // Wait for animation to finish }) .then(function() { x1 = gd._fullData[0].node.x.slice();