From 44568ad43f4048b508eb2900152c6f605fffe4ec Mon Sep 17 00:00:00 2001 From: yankev Date: Thu, 9 Jun 2016 18:16:27 -0400 Subject: [PATCH 1/5] changed descriptions of some histogram parameters --- src/traces/histogram/attributes.js | 24 ++++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/src/traces/histogram/attributes.js b/src/traces/histogram/attributes.js index a87fcd96ae2..c5ff4301996 100644 --- a/src/traces/histogram/attributes.js +++ b/src/traces/histogram/attributes.js @@ -82,15 +82,21 @@ module.exports = { role: 'style', description: [ 'Determines whether or not the x axis bin attributes are picked', - 'by an algorithm.' - ].join(' ') + 'by an algorithm. Note that this should be set to false if you', + 'want to manually set the number of bins using the attributes in', + 'xbins' + ].join(' ') }, nbinsx: { valType: 'integer', min: 0, dflt: 0, role: 'style', - description: 'Sets the number of x axis bins.' + description: [ + 'Specifies the desired amount of bins. This value will be used', + 'in an algorithm that will decide the optimal bin size such that the', + 'histogram best visualizes the distribution of the data' + ] }, xbins: makeBinsAttr('x'), @@ -99,8 +105,10 @@ module.exports = { dflt: true, role: 'style', description: [ - 'Determines whether or not the y axis bin attributes are picked', - 'by an algorithm.' + 'Determines whether or not the y axis bin attributes are picked', + 'by an algorithm. Note that this should be set to false if you', + 'want to manually set the number of bins using the attributes in', + 'ybins' ].join(' ') }, nbinsy: { @@ -108,7 +116,11 @@ module.exports = { min: 0, dflt: 0, role: 'style', - description: 'Sets the number of y axis bins.' + description: [ + 'Specifies the desired amount of bins. This value will be used', + 'in an algorithm that will decide the optimal bin size such that the', + 'histogram best visualizes the distribution of the data' + ] }, ybins: makeBinsAttr('y'), From e259d525e8bf9ba52cd4cbae552e7242d6b79e6f Mon Sep 17 00:00:00 2001 From: yankev Date: Thu, 9 Jun 2016 18:20:18 -0400 Subject: [PATCH 2/5] changed wording --- src/traces/histogram/attributes.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/traces/histogram/attributes.js b/src/traces/histogram/attributes.js index c5ff4301996..727f379c2e2 100644 --- a/src/traces/histogram/attributes.js +++ b/src/traces/histogram/attributes.js @@ -93,7 +93,7 @@ module.exports = { dflt: 0, role: 'style', description: [ - 'Specifies the desired amount of bins. This value will be used', + 'Specifies the maximum number of desired bins. This value will be used', 'in an algorithm that will decide the optimal bin size such that the', 'histogram best visualizes the distribution of the data' ] @@ -117,7 +117,7 @@ module.exports = { dflt: 0, role: 'style', description: [ - 'Specifies the desired amount of bins. This value will be used', + 'Specifies the maximum number of desired bins. This value will be used', 'in an algorithm that will decide the optimal bin size such that the', 'histogram best visualizes the distribution of the data' ] From 4d60e4fc093a29084a7e93fc3a8a64e2fd029b88 Mon Sep 17 00:00:00 2001 From: yankev Date: Thu, 9 Jun 2016 18:39:10 -0400 Subject: [PATCH 3/5] added periods --- src/traces/histogram/attributes.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/traces/histogram/attributes.js b/src/traces/histogram/attributes.js index 727f379c2e2..3565933db35 100644 --- a/src/traces/histogram/attributes.js +++ b/src/traces/histogram/attributes.js @@ -84,7 +84,7 @@ module.exports = { 'Determines whether or not the x axis bin attributes are picked', 'by an algorithm. Note that this should be set to false if you', 'want to manually set the number of bins using the attributes in', - 'xbins' + 'xbins.' ].join(' ') }, nbinsx: { @@ -95,7 +95,7 @@ module.exports = { description: [ 'Specifies the maximum number of desired bins. This value will be used', 'in an algorithm that will decide the optimal bin size such that the', - 'histogram best visualizes the distribution of the data' + 'histogram best visualizes the distribution of the data.' ] }, xbins: makeBinsAttr('x'), @@ -108,7 +108,7 @@ module.exports = { 'Determines whether or not the y axis bin attributes are picked', 'by an algorithm. Note that this should be set to false if you', 'want to manually set the number of bins using the attributes in', - 'ybins' + 'ybins.' ].join(' ') }, nbinsy: { @@ -119,7 +119,7 @@ module.exports = { description: [ 'Specifies the maximum number of desired bins. This value will be used', 'in an algorithm that will decide the optimal bin size such that the', - 'histogram best visualizes the distribution of the data' + 'histogram best visualizes the distribution of the data.' ] }, ybins: makeBinsAttr('y'), From a22ce0db067f11efea034c23f90cfd871e7d94ce Mon Sep 17 00:00:00 2001 From: yankev Date: Thu, 9 Jun 2016 18:50:58 -0400 Subject: [PATCH 4/5] added joins to fix strings --- src/traces/histogram/attributes.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/traces/histogram/attributes.js b/src/traces/histogram/attributes.js index 3565933db35..b1f72c20cc0 100644 --- a/src/traces/histogram/attributes.js +++ b/src/traces/histogram/attributes.js @@ -96,7 +96,7 @@ module.exports = { 'Specifies the maximum number of desired bins. This value will be used', 'in an algorithm that will decide the optimal bin size such that the', 'histogram best visualizes the distribution of the data.' - ] + ].join(' ') }, xbins: makeBinsAttr('x'), @@ -120,7 +120,7 @@ module.exports = { 'Specifies the maximum number of desired bins. This value will be used', 'in an algorithm that will decide the optimal bin size such that the', 'histogram best visualizes the distribution of the data.' - ] + ].join(' ') }, ybins: makeBinsAttr('y'), From 293ce37563e6c49ec477ceaf0df1774e21b7f7b1 Mon Sep 17 00:00:00 2001 From: yankev Date: Thu, 9 Jun 2016 19:27:49 -0400 Subject: [PATCH 5/5] fix indent issues --- src/traces/histogram/attributes.js | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/traces/histogram/attributes.js b/src/traces/histogram/attributes.js index b1f72c20cc0..5c687871080 100644 --- a/src/traces/histogram/attributes.js +++ b/src/traces/histogram/attributes.js @@ -85,7 +85,7 @@ module.exports = { 'by an algorithm. Note that this should be set to false if you', 'want to manually set the number of bins using the attributes in', 'xbins.' - ].join(' ') + ].join(' ') }, nbinsx: { valType: 'integer', @@ -93,9 +93,9 @@ module.exports = { dflt: 0, role: 'style', description: [ - 'Specifies the maximum number of desired bins. This value will be used', - 'in an algorithm that will decide the optimal bin size such that the', - 'histogram best visualizes the distribution of the data.' + 'Specifies the maximum number of desired bins. This value will be used', + 'in an algorithm that will decide the optimal bin size such that the', + 'histogram best visualizes the distribution of the data.' ].join(' ') }, xbins: makeBinsAttr('x'), @@ -105,10 +105,10 @@ module.exports = { dflt: true, role: 'style', description: [ - 'Determines whether or not the y axis bin attributes are picked', - 'by an algorithm. Note that this should be set to false if you', - 'want to manually set the number of bins using the attributes in', - 'ybins.' + 'Determines whether or not the y axis bin attributes are picked', + 'by an algorithm. Note that this should be set to false if you', + 'want to manually set the number of bins using the attributes in', + 'ybins.' ].join(' ') }, nbinsy: { @@ -117,9 +117,9 @@ module.exports = { dflt: 0, role: 'style', description: [ - 'Specifies the maximum number of desired bins. This value will be used', - 'in an algorithm that will decide the optimal bin size such that the', - 'histogram best visualizes the distribution of the data.' + 'Specifies the maximum number of desired bins. This value will be used', + 'in an algorithm that will decide the optimal bin size such that the', + 'histogram best visualizes the distribution of the data.' ].join(' ') }, ybins: makeBinsAttr('y'),