From 4edb5fc384a7a83f97a39eb5111e5b94ab445716 Mon Sep 17 00:00:00 2001 From: archmoj Date: Fri, 25 Jun 2021 13:33:27 -0400 Subject: [PATCH] decrease tolerance for flaky baselines namely mapbox --- test/image/compare_pixels_test.js | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/test/image/compare_pixels_test.js b/test/image/compare_pixels_test.js index 20f24b87d9e..87e7ee7a403 100644 --- a/test/image/compare_pixels_test.js +++ b/test/image/compare_pixels_test.js @@ -114,13 +114,17 @@ for(var i = 0; i < allMockList.length; i++) { height: height }); - var shouldBePixelPerfect = mockName.substr(0, 7) !== 'mapbox_' && [ + var isMapbox = mockName.substr(0, 7) === 'mapbox_'; + var isOtherFlaky = [ // list flaky mocks other than mapbox: 'gl3d_bunny-hull' - ].indexOf(mockName) === -1; + ].indexOf(mockName) !== -1; + + var shouldBePixelPerfect = !(isMapbox || isOtherFlaky); var numDiffPixels = pixelmatch(img0.data, img1.data, diff.data, width, height, { - threshold: shouldBePixelPerfect ? 0 : 0.2 + threshold: shouldBePixelPerfect ? 0 : + mockName === 'mapbox_geojson-attributes' ? 0.2 : 0.15 }); if(numDiffPixels) {