Skip to content

Commit fb07d66

Browse files
committed
use former instead of deprecated for retired v1 roles
1 parent 9c7bf87 commit fb07d66

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

test/jasmine/bundle_tests/plotschema_test.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ describe('plot schema', function() {
2525
var isPlainObject = Lib.isPlainObject;
2626

2727
var VALTYPES = Object.keys(valObjects);
28-
var deprecatedRoles = ['info', 'style', 'data'];
28+
var formerRoles = ['info', 'style', 'data'];
2929
var editType = plotSchema.defs.editType;
3030

3131
function assertTraceSchema(callback) {
@@ -73,11 +73,11 @@ describe('plot schema', function() {
7373
);
7474
});
7575

76-
it('all attributes should not have valid a deprecated `role`', function() {
76+
it('all attributes should not have a former `role`', function() {
7777
assertPlotSchema(
7878
function(attr) {
7979
if(isValObject(attr)) {
80-
expect(deprecatedRoles.indexOf(attr.role) === -1).toBe(true, attr);
80+
expect(formerRoles.indexOf(attr.role) === -1).toBe(true, attr);
8181
expect(attr.role).toBeUndefined(attr);
8282
}
8383
}
@@ -224,7 +224,7 @@ describe('plot schema', function() {
224224
);
225225
});
226226

227-
it('deprecated attributes should have a `valType` and not any deprecated roles', function() {
227+
it('deprecated attributes should have a `valType` and not any former roles', function() {
228228
var DEPRECATED = '_deprecated';
229229

230230
assertPlotSchema(
@@ -235,7 +235,7 @@ describe('plot schema', function() {
235235

236236
var msg = attrString + ': ' + dAttrName;
237237
expect(VALTYPES.indexOf(dAttr.valType) !== -1).toBe(true, msg);
238-
expect(deprecatedRoles.indexOf(dAttr.role) === -1).toBe(true, msg);
238+
expect(formerRoles.indexOf(dAttr.role) === -1).toBe(true, msg);
239239
expect(dAttr.role).toBeUndefined(msg);
240240
});
241241
}

0 commit comments

Comments
 (0)