fixup autotype for splom trace w/ visible false dims

Author: etpinard

src/plots/cartesian/type_defaults.js

@@ -65,14 +65,15 @@ function setAutoType(ax, data) {
 
     var calAttr = axLetter + 'calendar';
     var calendar = d0[calAttr];
+    var i;
 
     // check all boxes on this x axis to see
     // if they're dates, numbers, or categories
     if(isBoxWithoutPositionCoords(d0, axLetter)) {
         var posLetter = getBoxPosLetter(d0);
         var boxPositions = [];
 
-        for(var i = 0; i < data.length; i++) {
+        for(i = 0; i < data.length; i++) {
             var trace = data[i];
             if(!Registry.traceIs(trace, 'box-violin') ||
                (trace[axLetter + 'axis'] || axLetter) !== id) continue;
@@ -87,7 +88,14 @@ function setAutoType(ax, data) {
         ax.type = autoType(boxPositions, calendar);
     }
     else if(d0.type === 'splom') {
-        ax.type = autoType(d0.dimensions[0].values, calendar);
+        var dimensions = d0.dimensions;
+        for(i = 0; i < dimensions.length; i++) {
+            var dim = dimensions[i];
+            if(dim.visible) {
+                ax.type = autoType(dim.values, calendar);
+                break;
+            }
+        }
     }
     else {
         ax.type = autoType(d0[axLetter] || [d0[axLetter + '0']], calendar);

test/jasmine/tests/splom_test.js

@@ -139,4 +139,17 @@ describe('Test splom trace defaults:', function() {
         expect(fullLayout.xaxis.type).toBe('category');
         expect(fullLayout.yaxis.type).toBe('category');
     });
+
+    it('should lead to correct axis auto type value (case 2)', function() {
+        _supply({
+            dimensions: [
+                {visible: false, values: ['2018-01-01', '2018-02-01', '2018-03-03']},
+                {values: ['2018-01-01', '2018-02-01', '2018-03-03']}
+            ]
+        });
+
+        var fullLayout = gd._fullLayout;
+        expect(fullLayout.xaxis.type).toBe('date');
+        expect(fullLayout.yaxis.type).toBe('date');
+    });
 });