set visible:false if showupper & showlower & diagonal.visible are false

Author: etpinard

src/traces/splom/defaults.js

@@ -21,7 +21,12 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
     }
 
     var dimLength = handleDimensionsDefaults(traceIn, traceOut);
-    if(!dimLength) {
+
+    var showDiag = coerce('diagonal.visible');
+    var showUpper = coerce('showupperhalf');
+    var showLower = coerce('showlowerhalf');
+
+    if(!dimLength || (!showDiag && !showUpper && !showLower)) {
         traceOut.visible = false;
         return;
     }
@@ -34,13 +39,6 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
     var isBubble = subTypes.isBubble(traceOut);
     coerce('marker.line.width', isOpen || isBubble ? 1 : 0);
 
-    // TODO if all 3 below are false,
-    // should we set `visible: false` and exit early?
-
-    coerce('diagonal.visible');
-    coerce('showupperhalf');
-    coerce('showlowerhalf');
-
     handleAxisDefaults(traceIn, traceOut, layout, coerce);
 
     Lib.coerceSelectionMarkerOpacity(traceOut, coerce);

test/jasmine/tests/splom_test.js

@@ -24,14 +24,27 @@ describe('Test splom trace defaults:', function() {
         supplyAllDefaults(gd);
     }
 
-    it('should set to `visible: false` dimensions-less traces', function() {
+    it('should set `visible: false` dimensions-less traces', function() {
         _supply([{}, {dimensions: []}]);
 
         expect(gd._fullData[0].visible).toBe(false);
         expect(gd._fullData[1].visible).toBe(false);
     });
 
-    it('should set to `visible: false` to values-less dimensions', function() {
+    it('should set `visible: false` to traces with showupperhalf, showlowerhalf, and diagonal.visible false', function() {
+        _supply({
+            dimensions: [{
+                values: [1, 2, 3]
+            }],
+            showupperhalf: false,
+            showlowerhalf: false,
+            diagonal: {visible: false}
+        });
+
+        expect(gd._fullData[0].visible).toBe(false);
+    });
+
+    it('should set `visible: false` to values-less dimensions', function() {
         _supply({
             dimensions: [
                 'not-an-object',