a some test material

Author: etpinard

src/plots/plots.js

@@ -1373,7 +1373,6 @@ plots.supplyLayoutModuleDefaults = function(layoutIn, layoutOut, fullData, trans
     var basePlotModules = layoutOut._basePlotModules;
     var component, i, _module;
 
-
     var Cartesian = Registry.subplotsRegistry.cartesian;
 
     // check if any components need to add more base plot modules

src/traces/splom/defaults.js

@@ -22,8 +22,8 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
         return Lib.coerce(traceIn, traceOut, attributes, attr, dflt);
     }
 
-    var dimLen = handleDimensionsDefaults(traceIn, traceOut);
-    if(!dimLen) {
+    var dimLength = handleDimensionsDefaults(traceIn, traceOut);
+    if(!dimLength) {
         traceOut.visible = false;
         return;
     }
@@ -79,7 +79,7 @@ function handleDimensionsDefaults(traceIn, traceOut) {
         if(!visible) continue;
 
         var values = coerce('values');
-        if(!values.length) {
+        if(!values || values.length) {
             dimOut.visible = false;
             continue;
         }
@@ -101,20 +101,20 @@ function handleDimensionsDefaults(traceIn, traceOut) {
 }
 
 function handleAxisDefaults(traceIn, traceOut, layout, coerce) {
-    var dimLen = traceOut.dimensions.length;
-    var xaxesDflt = new Array(dimLen);
-    var yaxesDflt = new Array(dimLen);
+    var dimLength = traceOut.dimensions.length;
+    var xaxesDflt = new Array(dimLength);
+    var yaxesDflt = new Array(dimLength);
     var i;
 
-    for(i = 0; i < dimLen; i++) {
+    for(i = 0; i < dimLength; i++) {
         xaxesDflt[i] = 'x' + (i ? i + 1 : '');
         yaxesDflt[i] = 'y' + (i ? i + 1 : '');
     }
 
     var xaxes = coerce('xaxes', xaxesDflt);
     var yaxes = coerce('yaxes', yaxesDflt);
 
-    // TODO what to do when xaxes.length or yaxes.length !== dimLen ???
+    // TODO what to do when xaxes.length or yaxes.length !== dimLength ???
 
     for(i = 0; i < xaxes.length; i++) {
         Lib.pushUnique(layout._splomXaxes, xaxes[i]);

test/image/baselines/splom_0.png

@@ -0,0 +1,10 @@
+{
+  "data": [{
+    "type": "splom",
+    "dimensions": [{
+      "values": [1, 2, 1]
+    }, {
+      "values": [2, 5, 0]
+    }]
+  }]
+}

test/image/mocks/splom_0.json

@@ -0,0 +1,100 @@
+var Lib = require('@src/lib');
+var supplyAllDefaults = require('../assets/supply_defaults');
+
+describe('Test splom trace defaults:', function() {
+    var gd;
+
+    function _supply(opts, layout) {
+        gd = {};
+        opts = Array.isArray(opts) ? opts : [opts];
+
+        gd.data = opts.map(function(o) {
+            return Lib.extendFlat({type: 'splom'}, o || {});
+        });
+        gd.layout = layout || {};
+
+        supplyAllDefaults(gd);
+    }
+
+    it('should set to `visible: false` dimensions-less traces', function() {
+        _supply([{}, {dimensions: []}]);
+
+        expect(gd._fullData[0].visible).toBe(false);
+        expect(gd._fullData[1].visible).toBe(false);
+    });
+
+    it('should set to `visible: false` to values-less dimensions', function() {
+        _supply({
+            dimensions: [
+                'not-an-object',
+                {other: 'stuff'}
+            ]
+        });
+
+        expect(gd._fullData[0].dimensions[0].visible).toBe(false);
+        expect(gd._fullData[0].dimensions[1].visible).toBe(false);
+    });
+
+    it('should set `grid.xaxes` and `grid.yaxes` default using the new of dimensions', function() {
+        _supply({
+            dimensions: [
+                {values: [1, 2, 3]},
+                {values: [2, 1, 2]}
+            ]
+        });
+
+        var fullTrace = gd._fullData[0];
+        expect(fullTrace.xaxes).toEqual(['x', 'x2']);
+        expect(fullTrace.yaxes).toEqual(['y', 'y2']);
+
+        var fullLayout = gd._fullLayout;
+        expect(fullLayout.xaxis.domain).toBeCloseToArray([0, 0.47]);
+        expect(fullLayout.yaxis.domain).toBeCloseToArray([0.53, 1]);
+        expect(fullLayout.xaxis2.domain).toBeCloseToArray([0.53, 1]);
+        expect(fullLayout.yaxis2.domain).toBeCloseToArray([0, 0.47]);
+
+        var subplots = fullLayout._subplots;
+        expect(subplots.xaxis).toEqual(['x', 'x2']);
+        expect(subplots.yaxis).toEqual(['y', 'y2']);
+        expect(subplots.cartesian).toEqual(['xy', 'xy2', 'x2y', 'x2y2']);
+    });
+
+    it('should honor `grid.xaxes` and `grid.yaxes` settings', function() {
+        _supply({
+            dimensions: [
+                {values: [1, 2, 3]},
+                {values: [2, 1, 2]}
+            ]
+        }, {
+            grid: {domain: {x: [0, 0.5], y: [0, 0.5]}}
+        });
+
+        var fullLayout = gd._fullLayout;
+        expect(fullLayout.xaxis.domain).toBeCloseToArray([0, 0.24]);
+        expect(fullLayout.yaxis.domain).toBeCloseToArray([0.26, 0.5]);
+        expect(fullLayout.xaxis2.domain).toBeCloseToArray([0.26, 0.5]);
+        expect(fullLayout.yaxis2.domain).toBeCloseToArray([0, 0.24]);
+    });
+
+    it('should honor xaxis and yaxis settings', function() {
+        _supply({
+            dimensions: [
+                {values: [1, 2, 3]},
+                {values: [2, 1, 2]}
+            ]
+        }, {
+            xaxis: {domain: [0, 0.4]},
+            yaxis2: {domain: [0, 0.3]}
+        });
+
+        var fullLayout = gd._fullLayout;
+        expect(fullLayout.xaxis.domain).toBeCloseToArray([0, 0.4]);
+        expect(fullLayout.yaxis.domain).toBeCloseToArray([0.53, 1]);
+        expect(fullLayout.xaxis2.domain).toBeCloseToArray([0.53, 1]);
+        expect(fullLayout.yaxis2.domain).toBeCloseToArray([0, 0.3]);
+    });
+
+    it('should set axis title default using dimensions *label*', function() {
+        // TODO
+    });
+});