apply per dimension tickformat in linear axes ticktext

Author: archmoj

src/traces/parcoords/attributes.js

@@ -69,7 +69,7 @@ module.exports = {
             dflt: '3s',
             role: 'style',
             editType: 'plot',
-            description: [ // TODO: should update this description?
+            description: [
                 'Sets the tick label formatting rule using d3 formatting mini-language',
                 'which is similar to those of Python. See',
                 'https://github.com/d3/d3-format/blob/master/README.md#locale_format'

src/traces/parcoords/parcoords.js

@@ -11,6 +11,7 @@
 var d3 = require('d3');
 var rgba = require('color-rgba');
 
+var Axes = require('../../plots/cartesian/axes');
 var Lib = require('../../lib');
 var svgTextUtils = require('../../lib/svg_text_utils');
 var Drawing = require('../../components/drawing');
@@ -25,17 +26,6 @@ var c = require('./constants');
 var brush = require('./axisbrush');
 var lineLayerMaker = require('./lines');
 
-var tickText = require('../../plots/cartesian/axes').tickText;
-var parcoordsLayout;
-
-function linearFormat(v) {
-    return tickText(
-        parcoordsLayout.linearAxis,
-        parcoordsLayout.linearAxis.d2l(v),
-        true
-    ).text;
-}
-
 function visible(dimension) { return !('visible' in dimension) || dimension.visible; }
 
 function dimensionExtent(dimension) {
@@ -364,7 +354,21 @@ function calcTilt(angle) {
 module.exports = function(gd, svg, parcoordsLineLayers, cdModule, layout, callbacks) {
     var state = parcoordsInteractionState();
 
-    parcoordsLayout = layout;
+    var fullLayout = gd._fullLayout;
+
+    // mock one linear axes for tick formatting
+    var linearAxis = { type: 'linear', showexponent: 'all', exponentformat: 'B' };
+    Axes.setConvert(linearAxis, fullLayout);
+
+    function linearFormat(v, tickformat) {
+        linearAxis.tickformat = tickformat;
+
+        return Axes.tickText(
+            linearAxis,
+            linearAxis.d2l(v),
+            true
+        ).text;
+    }
 
     var vm = cdModule
         .filter(function(d) { return unwrap(d).trace.visible; })
@@ -579,7 +583,9 @@ module.exports = function(gd, svg, parcoordsLineLayers, cdModule, layout, callba
                     .tickValues(d.ordinal ? // and this works for ordinal scales
                         sdom :
                         null)
-                    .tickFormat(d.ordinal ? function(d) { return d; } : function(d) { return linearFormat(d); })
+                    .tickFormat(function(v) {
+                        return d.ordinal ? v : linearFormat(v, d.tickFormat);
+                    })
                     .scale(scale));
             Drawing.font(axis.selectAll('text'), d.model.tickFont);
         });
@@ -663,7 +669,7 @@ module.exports = function(gd, svg, parcoordsLineLayers, cdModule, layout, callba
         if(d.ordinal) return '';
         var domain = d.domainScale.domain();
         var v = (domain[isTop ? domain.length - 1 : 0]);
-        return linearFormat(v);
+        return linearFormat(v, d.tickFormat);
     }
 
     axisExtentTopText.enter()

src/traces/parcoords/plot.js

@@ -10,7 +10,6 @@
 
 var parcoords = require('./parcoords');
 var prepareRegl = require('../../lib/prepare_regl');
-var setConvert = require('../../plots/cartesian/axes').setConvert;
 
 module.exports = function plot(gd, cdModule) {
     var fullLayout = gd._fullLayout;
@@ -20,10 +19,6 @@ module.exports = function plot(gd, cdModule) {
     var success = prepareRegl(gd);
     if(!success) return;
 
-    // mock linear and category axes for tick formatting
-    var linearAxis = { type: 'linear', showexponent: 'all', exponentformat: 'B' };
-    setConvert(linearAxis, fullLayout);
-
     var gdDimensions = {};
     var gdDimensionsOriginalOrder = {};
     var fullIndices = {};
@@ -151,8 +146,7 @@ module.exports = function plot(gd, cdModule) {
                 r: size.r,
                 b: size.b,
                 l: size.l
-            },
-            linearAxis: linearAxis
+            }
         },
         { // callbacks
             filterChanged: filterChanged,

test/image/baselines/gl2d_parcoords.png

@@ -12,13 +12,15 @@
                     ]
                 },
                 {
+                    "tickformat": ".3f",
                     "label": "Bananas",
                     "values": [
                         -0.99999,
                         0.99999
                     ]
                 },
                 {
+                    "tickformat": ".6s",
                     "label": "Cherries",
                     "values": [
                         -0.99999,