Skip to content

Commit e6ca14a

Browse files
committed
make picking work properly with domain offset
1 parent 04baeae commit e6ca14a

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

src/traces/parcoords/parcoords.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -318,8 +318,8 @@ module.exports = function(root, svg, styledData, layout, callbacks) {
318318
var event = d3.event;
319319
var cw = this.width;
320320
var ch = this.height;
321-
var translateY = d.model.key * (d.model.height + d.model.pad.t + d.model.pad.b);
322-
var x = event.layerX - d.model.pad.l + c.overdrag;
321+
var translateY = d.model.key * (d.model.height + d.model.pad.t + d.model.pad.b) + d.model.translateY;
322+
var x = event.layerX - d.model.pad.l + c.overdrag - d.model.translateX;
323323
var y = event.layerY - d.model.pad.t - translateY;
324324
if(x < 0 || y < 0 || x >= cw || y >= ch) {
325325
return;

test/jasmine/tests/parcoords_test.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -494,6 +494,10 @@ describe('parcoords', function() {
494494

495495
beforeEach(function(done) {
496496
mockCopy = Lib.extendDeep({}, mock);
497+
mockCopy.data[0].domain = {
498+
x: [0.1, 0.9],
499+
y: [0.05, 0.85]
500+
};
497501
gd = createGraphDiv();
498502
Plotly.plot(gd, mockCopy.data, mockCopy.layout).then(done);
499503
});
@@ -661,15 +665,15 @@ describe('parcoords', function() {
661665

662666
expect(tester.get()).toBe(false);
663667

664-
mouseEvent('mousemove', 946, 234);
665-
mouseEvent('mouseover', 946, 234);
668+
mouseEvent('mousemove', 853, 254);
669+
mouseEvent('mouseover', 853, 254);
666670

667671
window.setTimeout(function() {
668672

669673
expect(tester.get().hover.curveNumber).toBe(4);
670674

671-
mouseEvent('mousemove', 110, 126);
672-
mouseEvent('mouseover', 110, 126);
675+
mouseEvent('mousemove', 800, 240);
676+
mouseEvent('mouseover', 800, 240);
673677

674678
window.setTimeout(function() {
675679

0 commit comments

Comments
 (0)