Skip to content

Commit e683025

Browse files
authored
Merge pull request #5791 from plotly/how-to-clone-your-fork
improve CONTRIBUTING and describe how to clone from your fork
2 parents 03917c6 + b62be42 commit e683025

File tree

2 files changed

+20
-7
lines changed

2 files changed

+20
-7
lines changed

CONTRIBUTING.md

Lines changed: 19 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -84,21 +84,33 @@ We use the following [labels](https://github.com/plotly/plotly.js/labels) to tra
8484
[`package-lock.json`](https://docs.npmjs.com/files/package-lock.json) file is
8585
used and updated correctly.
8686

87-
#### Step 1: Clone the plotly.js repo and install its dependencies
87+
#### Step 1: Fork the plotly.js repository, clone your fork and step into it
8888

8989
```bash
90-
git clone https://github.com/plotly/plotly.js.git
90+
git clone --depth 1 git@github.com:<your-GitHub-username>/plotly.js.git
9191
cd plotly.js
92+
```
93+
94+
#### Step 2: Switch to a dev branch
95+
96+
```bash
97+
# please do not use master or main for your dev branch
98+
git checkout dev-branch-name
99+
```
100+
101+
#### Step 3: Install dependencies
102+
103+
```bash
92104
npm install
93105
```
94106

95-
#### Step 2: Setup test environment
107+
#### Step 4: Setup test environment
96108

97109
```bash
98110
npm run pretest
99111
```
100112

101-
#### Step 3: Start the test dashboard
113+
#### Step 5: Start the test dashboard
102114

103115
```bash
104116
npm start
@@ -110,7 +122,7 @@ This command bundles up the source files with source maps using
110122
dev plotly.js bundle update every time a source file is saved) and opens up a
111123
tab in your browser.
112124

113-
#### Step 4: Open up the console and start developing
125+
#### Step 6: Open up the console and start developing
114126

115127
A typical workflow is to make some modifications to the source, update the
116128
test dashboard, inspect and debug the changes, then repeat. The test dashboard
@@ -138,13 +150,13 @@ Three additional helpers exist that are refreshed every second:
138150
There is also a search bar in the top right of the dashboard. This fuzzy-searches
139151
image mocks based on their file name and trace type.
140152

141-
#### Step 5: Regenerate plot-schema in "test" folder then review & commit potential changes
153+
#### Step 7: Regenerate plot-schema in "test" folder then review & commit potential changes
142154

143155
```bash
144156
npm run schema
145157
```
146158

147-
#### Step 6: Review & commit potential changes made to test/plot-schema.json
159+
#### Step 8: Review & commit potential changes made to test/plot-schema.json
148160

149161
> If you are editing attribute descriptions or implementing a new feature this file located in the test folder records the proposed changes to the API. Note that there is another plot-schema.json file located in the dist folder, which should only be updated by the maintainers at release time.
150162

draftlogs/5791_change.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
- Adjust CONTRIBUTING document on how to clone plotly.js and submit pull requests from your fork [[#5791](https://github.com/plotly/plotly.js/pull/5791)]

0 commit comments

Comments
 (0)