Skip to content

Commit e34efd5

Browse files
committed
DRYing up inefficient placeholder code 3
1 parent 20c4149 commit e34efd5

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/traces/parcoords/lines.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -271,8 +271,8 @@ module.exports = function(canvasGL, lines, canvasWidth, canvasHeight, data, unit
271271

272272
var previousAxisOrder = [];
273273

274-
var dims = d3.range(2).map(function() {return d3.range(4).map(function() {return d3.range(16)});});
275-
var lims = d3.range(2).map(function() {return d3.range(4).map(function() {return d3.range(16)});});
274+
var dims = d3.range(2).map(function() {return d3.range(4).map(function() {return new Float32Array(16);});});
275+
var lims = d3.range(2).map(function() {return d3.range(4).map(function() {return new Float32Array(16);});});
276276

277277
function renderGLParcoords(dimensionViews, setChanged, clearOnly) {
278278

@@ -304,11 +304,11 @@ module.exports = function(canvasGL, lines, canvasWidth, canvasHeight, data, unit
304304
var leftRight = [i, ii];
305305

306306
for(loHi = 0; loHi < 2; loHi++) {
307-
index = leftRight[loHi]
307+
index = leftRight[loHi];
308308
for(abcd = 0; abcd < 4; abcd++) {
309-
for (d = 0; d < 16; d++) {
309+
for(d = 0; d < 16; d++) {
310310
dims[loHi][abcd][d] = d + 16 * abcd === index ? 1 : 0;
311-
lims[loHi][abcd][d] = paddedUnit((!context && valid(d, 16 * abcd) ? orig(d + 16 * abcd).filter[loHi] : loHi)) + (2 * loHi - 1) * filterEpsilon;
311+
lims[loHi][abcd][d] = paddedUnit((!context && valid(d, 16 * abcd) ? orig(d + 16 * abcd).filter[loHi] : loHi)) + (2 * loHi - 1) * filterEpsilon;
312312
}
313313
}
314314
}

0 commit comments

Comments
 (0)