Skip to content

Commit d75e27d

Browse files
committed
undo gl3d
1 parent 8e058a8 commit d75e27d

File tree

3 files changed

+1
-4
lines changed

3 files changed

+1
-4
lines changed

draftlogs/6144_add.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
- Add `griddash` axis property to cartesian, polar, smith, ternary, geo and gl2d subplots and
1+
- Add `griddash` axis property to cartesian, polar, smith, ternary, geo and gl2d subplots and
22
add `griddash` and `minorgriddash` to `carpet` trace [[6144](https://github.com/plotly/plotly.js/pull/6144)],
33
with thanks to @njwhite for the contribution!

src/plots/gl3d/layout/axis_attributes.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,6 @@ module.exports = overrideAll({
107107
gridcolor: extendFlat({}, axesAttrs.gridcolor, // shouldn't this be on-par with 2D?
108108
{dflt: 'rgb(204, 204, 204)'}),
109109
gridwidth: axesAttrs.gridwidth,
110-
griddash: axesAttrs.griddash,
111110
zeroline: axesAttrs.zeroline,
112111
zerolinecolor: axesAttrs.zerolinecolor,
113112
zerolinewidth: axesAttrs.zerolinewidth,

src/plots/gl3d/layout/convert.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ function AxesOptions() {
3939

4040
this.gridEnable = [ true, true, true ];
4141
this.gridWidth = [ 1, 1, 1 ];
42-
this.gridDash = [ '', '', '' ];
4342
this.gridColor = [ [0, 0, 0, 1], [0, 0, 0, 1], [0, 0, 0, 1] ];
4443

4544
this.zeroEnable = [ true, true, true ];
@@ -94,7 +93,6 @@ proto.merge = function(fullLayout, sceneLayout) {
9493
if('showgrid' in axes) opts.gridEnable[i] = axes.showgrid;
9594
if('gridcolor' in axes) opts.gridColor[i] = str2RgbaArray(axes.gridcolor);
9695
if('gridwidth' in axes) opts.gridWidth[i] = axes.gridwidth;
97-
if('griddash' in axes) opts.gridDash[i] = axes.griddash;
9896

9997
// Remove zeroline if axis type is log
10098
// otherwise the zeroline is incorrectly drawn at 1 on log axes

0 commit comments

Comments
 (0)