do not show zeroline when it falls inside an axis break

etpinard · etpinard · commit d425373aad83 · 2020-03-03T11:49:54.000-05:00
diff --git a/src/plots/cartesian/axes.js b/src/plots/cartesian/axes.js
@@ -2849,6 +2849,7 @@ axes.shouldShowZeroLine = function(gd, ax, counterAxis) {
         (rng[0] * rng[1] <= 0) &&
         ax.zeroline &&
         (ax.type === 'linear' || ax.type === '-') &&
+        !(ax.breaks && ax.maskBreaks(0) === BADNUM) &&
         (
             clipEnds(ax, 0) ||
             !anyCounterAxLineAtZero(gd, ax, counterAxis, rng) ||

Original file line number	Diff line number	Diff line change
`@@ -2849,6 +2849,7 @@ axes.shouldShowZeroLine = function(gd, ax, counterAxis) {`
`2849`	`2849`	`(rng[0] * rng[1] <= 0) &&`
`2850`	`2850`	`ax.zeroline &&`
`2851`	`2851`	`(ax.type === 'linear' \|\| ax.type === '-') &&`
	`2852`	`+ !(ax.breaks && ax.maskBreaks(0) === BADNUM) &&`
`2852`	`2853`	`(`
`2853`	`2854`	`clipEnds(ax, 0) \|\|`
`2854`	`2855`	`!anyCounterAxLineAtZero(gd, ax, counterAxis, rng) \|\|`