Skip to content

Commit d0b10c3

Browse files
committed
removed marker color case for bar and histogram
1 parent dfc294c commit d0b10c3

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

src/traces/bar/defaults.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,12 +71,11 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
7171
handleStyleDefaults(traceIn, traceOut, coerce, defaultColor, layout);
7272

7373
var lineColor = (traceOut.marker.line || {}).color;
74-
var markerColor = (traceOut.marker || {}).color;
7574

7675
// override defaultColor for error bars with defaultLine
7776
var errorBarsSupplyDefaults = Registry.getComponentMethod('errorbars', 'supplyDefaults');
78-
errorBarsSupplyDefaults(traceIn, traceOut, lineColor || markerColor || Color.defaultLine, {axis: 'y'});
79-
errorBarsSupplyDefaults(traceIn, traceOut, lineColor || markerColor || Color.defaultLine, {axis: 'x', inherit: 'y'});
77+
errorBarsSupplyDefaults(traceIn, traceOut, lineColor || Color.defaultLine, {axis: 'y'});
78+
errorBarsSupplyDefaults(traceIn, traceOut, lineColor || Color.defaultLine, {axis: 'x', inherit: 'y'});
8079

8180
Lib.coerceSelectionMarkerOpacity(traceOut, coerce);
8281
};

src/traces/histogram/defaults.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,9 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
6565
Lib.coerceSelectionMarkerOpacity(traceOut, coerce);
6666

6767
var lineColor = (traceOut.marker.line || {}).color;
68-
var markerColor = (traceOut.marker || {}).color;
6968

7069
// override defaultColor for error bars with defaultLine
7170
var errorBarsSupplyDefaults = Registry.getComponentMethod('errorbars', 'supplyDefaults');
72-
errorBarsSupplyDefaults(traceIn, traceOut, lineColor || markerColor || Color.defaultLine, {axis: 'y'});
73-
errorBarsSupplyDefaults(traceIn, traceOut, lineColor || markerColor || Color.defaultLine, {axis: 'x', inherit: 'y'});
71+
errorBarsSupplyDefaults(traceIn, traceOut, lineColor || Color.defaultLine, {axis: 'y'});
72+
errorBarsSupplyDefaults(traceIn, traceOut, lineColor || Color.defaultLine, {axis: 'x', inherit: 'y'});
7473
};

0 commit comments

Comments
 (0)