Skip to content

Commit d02f572

Browse files
committed
clear regl colors once per drawData pass
- as opposed to once per basePlotModule pass, that way scattergl and splom can coexist - this introduces an additional 'clear' call for parcoords trace. No side-effect were detected. But we should double-check - add first cut splom + cartesian mock
1 parent c0c5a6e commit d02f572

File tree

3 files changed

+38
-2
lines changed

3 files changed

+38
-2
lines changed

src/traces/splom/base_plot.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -168,8 +168,6 @@ function showZeroLine(ax) {
168168
}
169169

170170
function clean(newFullData, newFullLayout, oldFullData, oldFullLayout, oldCalcdata) {
171-
oldCalcdata = oldCalcdata || [];
172-
173171
var oldModules = oldFullLayout._modules || [];
174172
var newModules = newFullLayout._modules || [];
175173

23.3 KB
Loading
Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
{
2+
"data": [{
3+
"type": "splom",
4+
"name": "splom",
5+
"dimensions": [{
6+
"values": [1, 2, 3],
7+
"label": "A"
8+
}, {
9+
"values": [2, 5, 6],
10+
"label": "B"
11+
}]
12+
}, {
13+
"name": "scatter",
14+
"y": [1, 2, 1]
15+
}, {
16+
"type": "box",
17+
"name": "box",
18+
"x0": 0,
19+
"y": [1, 2, 2, 2, 2, 3, 3, 3, 3, 3, 4, 4, 6],
20+
"yaxis": "y2"
21+
}, {
22+
"type": "scattergl",
23+
"name": "scattergl",
24+
"y": [1, 2, 1],
25+
"xaxis": "x2"
26+
}],
27+
"layout": {
28+
"grid": {
29+
"roworder": "bottom to top"
30+
},
31+
"legend": {
32+
"x": 0,
33+
"y": 1.1,
34+
"yanchor": "bottom",
35+
"orientation": "h"
36+
}
37+
}
38+
}

0 commit comments

Comments
 (0)