Fixed a bug where event data in scatter3d charts was always undefined

dwoznicki · dwoznicki · commit cc9b69593b0a · 2021-09-28T16:03:16.000-07:00
diff --git a/src/plots/gl3d/scene.js b/src/plots/gl3d/scene.js
@@ -332,8 +332,6 @@ proto.render = function() {
         return Axes.hoverLabelText(ax, val, hoverformat);
     }
 
-    var oldEventData;
-
     if(lastPicked !== null) {
         var pdata = project(scene.glplot.cameraParams, selection.dataCoordinate);
         trace = lastPicked.data;
@@ -456,10 +454,11 @@ proto.render = function() {
             gd.emit('plotly_hover', eventData);
         }
 
-        oldEventData = eventData;
+        this.oldEventData = eventData;
     } else {
         Fx.loneUnhover(svgContainer);
-        gd.emit('plotly_unhover', oldEventData);
+        gd.emit('plotly_unhover', this.oldEventData);
+        this.oldEventData = undefined;
     }
 
     scene.drawAnnotations(scene);

Original file line number	Diff line number	Diff line change
`@@ -332,8 +332,6 @@ proto.render = function() {`
`332`	`332`	`return Axes.hoverLabelText(ax, val, hoverformat);`
`333`	`333`	`}`
`334`	`334`
`335`		`- var oldEventData;`
`336`		`-`
`337`	`335`	`if(lastPicked !== null) {`
`338`	`336`	`var pdata = project(scene.glplot.cameraParams, selection.dataCoordinate);`
`339`	`337`	`trace = lastPicked.data;`
`@@ -456,10 +454,11 @@ proto.render = function() {`
`456`	`454`	`gd.emit('plotly_hover', eventData);`
`457`	`455`	`}`
`458`	`456`
`459`		`- oldEventData = eventData;`
	`457`	`+ this.oldEventData = eventData;`
`460`	`458`	`} else {`
`461`	`459`	`Fx.loneUnhover(svgContainer);`
`462`		`- gd.emit('plotly_unhover', oldEventData);`
	`460`	`+ gd.emit('plotly_unhover', this.oldEventData);`
	`461`	`+ this.oldEventData = undefined;`
`463`	`462`	`}`
`464`	`463`
`465`	`464`	`scene.drawAnnotations(scene);`