Fix autorange computation when a category match a range extreme

Author: LoganWlv

src/plots/cartesian/set_convert.js

@@ -180,11 +180,15 @@ module.exports = function setConvert(ax, fullLayout) {
     function getCategoryPosition(v) {
         // d2l/d2c variant that that won't add categories but will also
         // allow numbers to be mapped to the linearized axis positions
-        var index = getCategoryIndex(v);
+        var index = getRangePosition(v);
         if(index !== undefined) return index;
         if(isNumeric(v)) return +v;
     }
 
+    function getRangePosition(v) {
+        return isNumeric(v) ? +v : getCategoryIndex(v);
+    }
+
     // include 2 fractional digits on pixel, for PDF zooming etc
     function _l2p(v, m, b) { return d3.round(b + m * v, 2); }
 

test/image/mocks/bar_max_range_eq_category.json

@@ -0,0 +1,26 @@
+{
+  "data": [{
+    "x" : [ "1.5", "2.5", "3.5", "6.5", "7.5", "8.5", "10.5", "Not Known" ],
+    "y" : [ "1.0", "1.0", "2.0", "1.0", "1.0", "2.0", "1.0", "1.0" ],
+    "name" : "Double with string \"N/A\" Exposure",
+    "type" : "bar",
+    "showlegend" : false,
+    "visible" : true
+  } ],
+  "layout": {
+    "xaxis" : {
+      "type" : "category",
+      "showticklabels" : true,
+      "zeroline" : false,
+      "fixedrange" : false,
+      "showgrid" : false,
+      "autorange" : true,
+      "autotick" : true,
+      "showline" : false,
+      "visible" : true,
+      "automargin" : false
+    },
+    "toResize" : true,
+    "showlegend" : true
+  }
+}

test/jasmine/tests/axes_test.js

@@ -1779,6 +1779,15 @@ describe('Test axes', function() {
                 expect(gd._fullLayout.xaxis.categoryarray).toEqual(['b', 'a', 'd', 'e', 'c']);
             });
         });
+
+        describe('a category has the same value of one of the auto range computed extreme', function() {
+            it('should compute the right range for X axis', function() {
+                Plotly.plot(gd, [{x: ['1.5', '2.5', '3.5', '6.5', '7.5', '8.5', 'Not Known'], y: [ '1.0', '1.0', '2.0', '1.0', '1.0', '2.0', '1.0'], type: 'bar'}], {
+                    xaxis: {type: 'category', autorange: true}
+                });
+                expect(gd._fullLayout.xaxis._rl).toEqual([-0.5, 6.5]);
+            });
+        });
     });
 
     describe('handleTickDefaults', function() {

test/jasmine/tests/mock_test.js

@@ -118,6 +118,7 @@ var list = [
     'bar_hide_nulls',
     'bar_line',
     'bar_marker_array',
+    'bar_max_range_eq_category',
     'bar_multiline_labels',
     'bar_nonnumeric_sizes',
     'bar_show_narrow',
@@ -1181,6 +1182,7 @@ figs['bar_group_percent'] = require('@mocks/bar_group_percent');
 figs['bar_hide_nulls'] = require('@mocks/bar_hide_nulls');
 figs['bar_line'] = require('@mocks/bar_line');
 figs['bar_marker_array'] = require('@mocks/bar_marker_array');
+figs['bar_max_range_eq_category'] = require('@mocks/bar_max_range_eq_category');
 figs['bar_multiline_labels'] = require('@mocks/bar_multiline_labels');
 figs['bar_nonnumeric_sizes'] = require('@mocks/bar_nonnumeric_sizes');
 figs['bar_show_narrow'] = require('@mocks/bar_show_narrow');