change Lib.randstr warning to a throw error

Author: archmoj

src/lib/index.js

@@ -274,7 +274,7 @@ lib.simpleMap = function(array, func, x1, x2, opts) {
  * @param {int} base
  *     base of string representation, default 16. Should be a power of 2.
  */
-lib.randstr = function randstr(gd, existing, bits, base, _recursion) {
+lib.randstr = function randstr(existing, bits, base, _recursion) {
     if(!base) base = 16;
     if(bits === undefined) bits = 24;
     if(bits <= 0) return '0';
@@ -304,10 +304,9 @@ lib.randstr = function randstr(gd, existing, bits, base, _recursion) {
     if((existing && existing[res]) ||
          (parsed !== Infinity && parsed >= Math.pow(2, bits))) {
         if(_recursion > 10) {
-            lib.warn(gd, 'randstr failed uniqueness');
-            return res;
+            throw new Error('randstr failed uniqueness');
         }
-        return randstr(gd, existing, bits, base, (_recursion || 0) + 1);
+        return randstr(existing, bits, base, (_recursion || 0) + 1);
     } else return res;
 };
 

src/lib/svg_text_utils.js

@@ -191,7 +191,7 @@ function texToSVG(gd, _texString, _config, _callback) {
         }
     },
     function() {
-        var randomID = 'math-output-' + Lib.randstr(gd, {}, 64);
+        var randomID = 'math-output-' + Lib.randstr({}, 64);
         tmpDiv = d3.select('body').append('div')
             .attr({id: randomID})
             .style({visibility: 'hidden', position: 'absolute'})

src/plot_api/plot_api.js

@@ -3757,7 +3757,7 @@ function makePlotFramework(gd) {
         d3.selectAll('defs').each(function() {
             if(this.id) otherUids[this.id.split('-')[1]] = 1;
         });
-        fullLayout._uid = Lib.randstr(gd, otherUids);
+        fullLayout._uid = Lib.randstr(otherUids);
     }
 
     fullLayout._paperdiv.selectAll('.main-svg')

src/plot_api/to_image.js

@@ -200,7 +200,7 @@ function toImage(gd, opts) {
             }
 
             var canvas = document.createElement('canvas');
-            canvas.id = Lib.randstr(gd);
+            canvas.id = Lib.randstr();
 
             svgToImg({
                 format: format,

src/plots/plots.js

@@ -605,7 +605,7 @@ function getTraceUids(gd, oldFullData, newData) {
 
         if(tryUid(newUid, i)) continue;
         if(i < oldLen && tryUid(oldFullInput[i].uid, i)) continue;
-        setUid(Lib.randstr(gd, seenUids), i);
+        setUid(Lib.randstr(seenUids), i);
     }
 
     return out;

src/snapshot/toimage.js

@@ -42,7 +42,7 @@ function toImage(gd, opts) {
             var svg = toSVG(clonedGd);
 
             var canvas = document.createElement('canvas');
-            canvas.id = Lib.randstr(gd);
+            canvas.id = Lib.randstr();
 
             ev = svgToImg({
                 format: opts.format,

src/traces/sankey/render.js

@@ -261,7 +261,7 @@ function sankeyModel(gd, layout, d, traceIndex) {
         circular: circular,
         key: traceIndex,
         trace: trace,
-        guid: Lib.randstr(gd),
+        guid: Lib.randstr(),
         horizontal: horizontal,
         width: width,
         height: height,
@@ -477,7 +477,7 @@ function nodeModel(gd, d, n) {
     var key = 'node_' + n.pointNumber;
     // If it's a group, it's mutable and should be unique
     if(n.group) {
-        key = Lib.randstr(gd);
+        key = Lib.randstr();
     }
 
     // for event data

src/traces/sunburst/calc.js

@@ -114,7 +114,7 @@ exports.calc = function(gd, trace) {
             return Lib.warn(gd, 'Multiple implied roots, cannot build ' + trace.type + ' hierarchy.');
         }
     } else if(parent2children[''].length > 1) {
-        var dummyId = Lib.randstr(gd);
+        var dummyId = Lib.randstr();
 
         // if multiple rows linked to the root node,
         // add dummy "root of roots" node to make d3 build the hierarchy successfully

test/jasmine/tests/transform_groupby_test.js

@@ -17,7 +17,7 @@ function supplyDataDefaults(gd, dataIn, dataOut) {
         _modules: [],
         _visibleModules: [],
         _basePlotModules: [],
-        _traceUids: dataIn.map(function() { return Lib.randstr(gd); })
+        _traceUids: dataIn.map(function() { return Lib.randstr(); })
     });
 }