Skip to content

Commit b00966c

Browse files
committed
clean up some comments
1 parent 10dff2c commit b00966c

File tree

4 files changed

+15
-34
lines changed

4 files changed

+15
-34
lines changed

circle.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
general:
22
artifacts:
3-
- "build/test_images/" # relative to the build directory
4-
- "build/test_images_diff/" # relative to the build directory
3+
- "build/test_images/"
4+
- "build/test_images_diff/"
55

66
machine:
77
node:
8-
version: 4.2.1
8+
version: 4.2.1
99
services:
1010
- docker
11-
11+
1212

1313
dependencies:
14-
pre:
14+
pre:
1515
- docker pull plotly/imageserver:latest
1616
post:
1717
- npm run cibuild

tasks/baseline.sh

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2,23 +2,12 @@
22
#
33
# TODO adapt this for Windows
44
#
5-
# TODO add package.json config arguments to configure:
6-
# - container name,
7-
# - ports and
8-
# - imageserver version
9-
#
105
# ===============================================================================
116

12-
CONTAINER_NAME="imagetest"
13-
IMAGE_NAME="registry.plot.ly:5000/imageserver"
14-
IMAGE_VERSION="1.3.0"
7+
CONTAINER_NAME="imagetest" # same as in docker-compose.yml
158

16-
# Run docker container:
17-
#
18-
# docker run -d --name $CONTAINER_NAME \
19-
# -v $PWD/plotly.js:/var/www/streambed/image_server/plotly.js \
20-
# -p 9010:9010 -p 2022:22 \
21-
# $IMAGE_NAME:[$IMAGE_VERSION]
9+
# create/run/start docker container with:
10+
# $ docker-compose up -d
2211

2312
CMD=(
2413
"cd /var/www/streambed/image_server/plotly.js &&"

tasks/test_image.sh

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2,23 +2,12 @@
22
#
33
# TODO adapt this for Windows
44
#
5-
# TODO add package.json config arguments to configure:
6-
# - container name,
7-
# - ports and
8-
# - imageserver version
9-
#
105
# ===============================================================================
116

12-
CONTAINER_NAME="imagetest"
13-
IMAGE_NAME="registry.plot.ly:5000/imageserver"
14-
IMAGE_VERSION="1.3.0"
7+
CONTAINER_NAME="imagetest" # same as in docker-compose.yml
158

16-
# Run docker container:
17-
#
18-
# docker run -d --name $CONTAINER_NAME \
19-
# -v $PWD/plotly.js:/var/www/streambed/image_server/plotly.js \
20-
# -p 9010:9010 -p 2022:22 \
21-
# $IMAGE_NAME:[$IMAGE_VERSION]
9+
# create/run/start docker container with:
10+
# $ docker-compose up -d
2211

2312
CMD=(
2413
"cd /var/www/streambed/image_server/plotly.js &&"

test/image/README.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,9 @@ docker images
7171
docker ps -a
7272
```
7373

74+
whereas `docker ps` lists only the started containers.
75+
76+
7477
### Stop your testing container
7578

7679
Inside your `plotly.js` directory, run
@@ -87,4 +90,4 @@ Inside your `plotly.js` directory, run
8790
docker-compose rm -f
8891
```
8992

90-
For more comprehensive information about docker, please refer to [docker document](http://docs.docker.com/)
93+
For more comprehensive information about docker, please refer to the [docker docs](http://docs.docker.com/).

0 commit comments

Comments
 (0)