Skip to content

Commit afc05c9

Browse files
committed
stop slicing data arrays in scattergeo
1 parent 8fbe06e commit afc05c9

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

src/traces/scattergeo/calc.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ var _ = require('../../lib')._;
2020

2121
module.exports = function calc(gd, trace) {
2222
var hasLocationData = Array.isArray(trace.locations);
23-
var len = hasLocationData ? trace.locations.length : trace.lon.length;
23+
var len = hasLocationData ? trace.locations.length : trace._length;
2424
var calcTrace = new Array(len);
2525

2626
for(var i = 0; i < len; i++) {

src/traces/scattergeo/defaults.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,7 @@ function handleLonLatLocDefaults(traceIn, traceOut, coerce) {
6969
lon = coerce('lon') || [];
7070
lat = coerce('lat') || [];
7171
len = Math.min(lon.length, lat.length);
72-
73-
if(len < lon.length) traceOut.lon = lon.slice(0, len);
74-
if(len < lat.length) traceOut.lat = lat.slice(0, len);
72+
traceOut._length = len;
7573

7674
return len;
7775
}

test/image/mocks/geo_first.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@
99
{
1010
"type": "choropleth",
1111
"locations": ["USA", "CAN", "RUS"],
12-
"z": [0, 5, 10]
12+
"z": [0, 5, 10],
13+
"autocolorscale": true
1314
}
1415
],
1516
"layout": {

0 commit comments

Comments
 (0)