Skip to content

Commit a422094

Browse files
piePattern : lint fix & d3 call style
1 parent 5d809b6 commit a422094

File tree

2 files changed

+2
-7
lines changed

2 files changed

+2
-7
lines changed

src/components/drawing/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -633,7 +633,7 @@ drawing.singlePointStyle = function(d, sel, trace, fns, gd, pt) {
633633
var marker = trace.marker;
634634
var markerLine = marker.line;
635635

636-
if( pt && pt.i>=0 && d.i === undefined) d.i = pt.i;
636+
if(pt && pt.i >= 0 && d.i === undefined) d.i = pt.i;
637637

638638
sel.style('opacity',
639639
fns.selectedOpacityFn ? fns.selectedOpacityFn(d) :

src/traces/pie/style_one.js

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,19 +11,14 @@ module.exports = function styleOne(s, pt, trace, gd) {
1111

1212
// enforce the point color, when colors (with s) & the pattern shape are missing.
1313
// 'abuse' the color attribute, used in the Drawing component for bar trace type.
14-
// alternative: could be to pass the point color as an extra parameter in pointStyle
15-
// alternative: could be to activate pattern also for funnelarea
1614
var marker = trace.marker;
1715
if(marker.pattern) {
1816
if(!marker.colors || !marker.pattern.shape) marker.color = pt.color;
1917
} else {
2018
marker.color = pt.color;
2119
}
2220

23-
Drawing.pointStyle(s, trace, gd, pt);
24-
// to do : push into s.style d3 logic
25-
2621
s.style('stroke-width', lineWidth)
27-
// .call(Color.fill, pt.color)
22+
.call(Drawing.pointStyle, trace, gd, pt)
2823
.call(Color.stroke, lineColor);
2924
};

0 commit comments

Comments
 (0)