draw polar axis ticks above axis lines

- this is on-par with how cartesian draw things.
- update baselines
- update layer order jasmine tests now that axis lines are below ticks

Author: etpinard

src/plots/polar/constants.js

@@ -22,13 +22,10 @@ module.exports = {
         'angular-grid',
         'radial-grid',
         'frontplot',
-        'angular-axis',
-        'radial-axis',
-        // TODO hmm, putting angular-line above radial-axis
-        // can sometimes hide radial ticks and label
-        // this happens especially for the 'inner' angular axis
         'angular-line',
-        'radial-line'
+        'radial-line',
+        'angular-axis',
+        'radial-axis'
     ],
 
     radialDragBoxSize: 50,

src/plots/polar/polar.js

@@ -104,17 +104,17 @@ proto.updateLayers = function(fullLayout, polarLayout) {
     var isAngularAxisBelowTraces = angularLayout.layer === 'below traces';
     var isRadialAxisBelowTraces = radialLayout.layer === 'below traces';
 
-    if(isAngularAxisBelowTraces) layerData.push('angular-axis');
-    if(isRadialAxisBelowTraces) layerData.push('radial-axis');
     if(isAngularAxisBelowTraces) layerData.push('angular-line');
     if(isRadialAxisBelowTraces) layerData.push('radial-line');
+    if(isAngularAxisBelowTraces) layerData.push('angular-axis');
+    if(isRadialAxisBelowTraces) layerData.push('radial-axis');
 
     layerData.push('frontplot');
 
-    if(!isAngularAxisBelowTraces) layerData.push('angular-axis');
-    if(!isRadialAxisBelowTraces) layerData.push('radial-axis');
     if(!isAngularAxisBelowTraces) layerData.push('angular-line');
     if(!isRadialAxisBelowTraces) layerData.push('radial-line');
+    if(!isAngularAxisBelowTraces) layerData.push('angular-axis');
+    if(!isRadialAxisBelowTraces) layerData.push('radial-axis');
 
     var join = _this.framework.selectAll('.polarsublayer')
         .data(layerData, String);

test/image/baselines/glpolar_scatter.png

@@ -236,29 +236,29 @@ describe('Test relayout on polar subplots:', function() {
         .then(function() {
             _assert([
                 'draglayer', 'plotbg', 'backplot', 'angular-grid', 'radial-grid',
-                'radial-axis', 'radial-line',
+                'radial-line', 'radial-axis',
                 'frontplot',
-                'angular-axis', 'angular-line'
+                'angular-line', 'angular-axis'
             ]);
             return Plotly.relayout(gd, 'polar.angularaxis.layer', 'below traces');
         })
         .then(function() {
             _assert([
                 'draglayer', 'plotbg', 'backplot', 'angular-grid', 'radial-grid',
-                'angular-axis',
-                'radial-axis',
                 'angular-line',
                 'radial-line',
+                'angular-axis',
+                'radial-axis',
                 'frontplot'
             ]);
             return Plotly.relayout(gd, 'polar.radialaxis.layer', 'above traces');
         })
         .then(function() {
             _assert([
                 'draglayer', 'plotbg', 'backplot', 'angular-grid', 'radial-grid',
-                'angular-axis', 'angular-line',
+                'angular-line', 'angular-axis',
                 'frontplot',
-                'radial-axis', 'radial-line'
+                'radial-line', 'radial-axis'
             ]);
             return Plotly.relayout(gd, 'polar.angularaxis.layer', null);
         })