Skip to content

Commit 9959341

Browse files
committed
fix histogram2d test for _count field
1 parent 968f742 commit 9959341

File tree

1 file changed

+16
-16
lines changed

1 file changed

+16
-16
lines changed

test/jasmine/tests/histogram2d_test.js

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -169,42 +169,42 @@ describe('Test histogram2d', function() {
169169
1, 2, 3, 4, 1, 2, 3, 4, 1, 2, 3, 4, 1, 2, 3, 4,
170170
1, 2, 3, 4, 1, 2, 3, 4, 1, 2, 3, 4, 1, 2, 3, 4];
171171
Plotly.newPlot(gd, [{type: 'histogram2d', x: x1, y: y1}]);
172-
expect(gd._fullData[0].xbins).toEqual({start: 0.5, end: 4.5, size: 1});
173-
expect(gd._fullData[0].ybins).toEqual({start: 0.5, end: 4.5, size: 1});
172+
expect(gd._fullData[0].xbins).toEqual({start: 0.5, end: 4.5, size: 1, _count: 4});
173+
expect(gd._fullData[0].ybins).toEqual({start: 0.5, end: 4.5, size: 1, _count: 4});
174174
expect(gd._fullData[0].autobinx).toBe(true);
175175
expect(gd._fullData[0].autobiny).toBe(true);
176176

177177
// same range but fewer samples increases sizes
178178
Plotly.restyle(gd, {x: [[1, 3, 4]], y: [[1, 2, 4]]});
179-
expect(gd._fullData[0].xbins).toEqual({start: -0.5, end: 5.5, size: 2});
180-
expect(gd._fullData[0].ybins).toEqual({start: -0.5, end: 5.5, size: 2});
179+
expect(gd._fullData[0].xbins).toEqual({start: -0.5, end: 5.5, size: 2, _count: 3});
180+
expect(gd._fullData[0].ybins).toEqual({start: -0.5, end: 5.5, size: 2, _count: 3});
181181
expect(gd._fullData[0].autobinx).toBe(true);
182182
expect(gd._fullData[0].autobiny).toBe(true);
183183

184184
// larger range
185185
Plotly.restyle(gd, {x: [[10, 30, 40]], y: [[10, 20, 40]]});
186-
expect(gd._fullData[0].xbins).toEqual({start: -0.5, end: 59.5, size: 20});
187-
expect(gd._fullData[0].ybins).toEqual({start: -0.5, end: 59.5, size: 20});
186+
expect(gd._fullData[0].xbins).toEqual({start: -0.5, end: 59.5, size: 20, _count: 3});
187+
expect(gd._fullData[0].ybins).toEqual({start: -0.5, end: 59.5, size: 20, _count: 3});
188188
expect(gd._fullData[0].autobinx).toBe(true);
189189
expect(gd._fullData[0].autobiny).toBe(true);
190190

191191
// explicit changes to bin settings
192192
Plotly.restyle(gd, 'xbins.start', 12);
193-
expect(gd._fullData[0].xbins).toEqual({start: 12, end: 59.5, size: 20});
194-
expect(gd._fullData[0].ybins).toEqual({start: -0.5, end: 59.5, size: 20});
193+
expect(gd._fullData[0].xbins).toEqual({start: 12, end: 59.5, size: 20, _count: 3});
194+
expect(gd._fullData[0].ybins).toEqual({start: -0.5, end: 59.5, size: 20, _count: 3});
195195
expect(gd._fullData[0].autobinx).toBe(false);
196196
expect(gd._fullData[0].autobiny).toBe(true);
197197

198198
Plotly.restyle(gd, {'ybins.end': 12, 'ybins.size': 3});
199-
expect(gd._fullData[0].xbins).toEqual({start: 12, end: 59.5, size: 20});
200-
expect(gd._fullData[0].ybins).toEqual({start: -0.5, end: 12, size: 3});
199+
expect(gd._fullData[0].xbins).toEqual({start: 12, end: 59.5, size: 20, _count: 3});
200+
expect(gd._fullData[0].ybins).toEqual({start: -0.5, end: 12, size: 3, _count: 3});
201201
expect(gd._fullData[0].autobinx).toBe(false);
202202
expect(gd._fullData[0].autobiny).toBe(false);
203203

204204
// restart autobin
205205
Plotly.restyle(gd, {autobinx: true, autobiny: true});
206-
expect(gd._fullData[0].xbins).toEqual({start: -0.5, end: 59.5, size: 20});
207-
expect(gd._fullData[0].ybins).toEqual({start: -0.5, end: 59.5, size: 20});
206+
expect(gd._fullData[0].xbins).toEqual({start: -0.5, end: 59.5, size: 20, _count: 3});
207+
expect(gd._fullData[0].ybins).toEqual({start: -0.5, end: 59.5, size: 20, _count: 3});
208208
expect(gd._fullData[0].autobinx).toBe(true);
209209
expect(gd._fullData[0].autobiny).toBe(true);
210210
});
@@ -217,15 +217,15 @@ describe('Test histogram2d', function() {
217217
1, 2, 3, 4, 1, 2, 3, 4, 1, 2, 3, 4, 1, 2, 3, 4,
218218
1, 2, 3, 4, 1, 2, 3, 4, 1, 2, 3, 4, 1, 2, 3, 4];
219219
Plotly.newPlot(gd, [{type: 'histogram2d', x: x1, y: y1, autobinx: false, autobiny: false}]);
220-
expect(gd._fullData[0].xbins).toEqual({start: 0.5, end: 4.5, size: 1});
221-
expect(gd._fullData[0].ybins).toEqual({start: 0.5, end: 4.5, size: 1});
220+
expect(gd._fullData[0].xbins).toEqual({start: 0.5, end: 4.5, size: 1, _count: 4});
221+
expect(gd._fullData[0].ybins).toEqual({start: 0.5, end: 4.5, size: 1, _count: 4});
222222
expect(gd._fullData[0].autobinx).toBe(false);
223223
expect(gd._fullData[0].autobiny).toBe(false);
224224

225225
// with autobin false this will no longer update the bins.
226226
Plotly.restyle(gd, {x: [[1, 3, 4]], y: [[1, 2, 4]]});
227-
expect(gd._fullData[0].xbins).toEqual({start: 0.5, end: 4.5, size: 1});
228-
expect(gd._fullData[0].ybins).toEqual({start: 0.5, end: 4.5, size: 1});
227+
expect(gd._fullData[0].xbins).toEqual({start: 0.5, end: 4.5, size: 1, _count: 4});
228+
expect(gd._fullData[0].ybins).toEqual({start: 0.5, end: 4.5, size: 1, _count: 4});
229229
expect(gd._fullData[0].autobinx).toBe(false);
230230
expect(gd._fullData[0].autobiny).toBe(false);
231231
});

0 commit comments

Comments
 (0)