Skip to content

Commit 8d5da73

Browse files
committed
commet push options - add TODO comment to address issue 3292
1 parent e49fc41 commit 8d5da73

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

src/plots/cartesian/axes.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3058,7 +3058,7 @@ axes.drawLabels = function(gd, ax, opts) {
30583058
if(!ticklabeloverflow || ticklabeloverflow === 'allow') return;
30593059

30603060
var hideOverflow = ticklabeloverflow.indexOf('hide') !== -1;
3061-
var pushOverflow = ticklabeloverflow.indexOf('push') !== -1;
3061+
// var pushOverflow = ticklabeloverflow.indexOf('push') !== -1;
30623062

30633063
var isX = ax._id.charAt(0) === 'x';
30643064
// div positions
@@ -3100,10 +3100,13 @@ axes.drawLabels = function(gd, ax, opts) {
31003100
var t = thisLabel.select('text');
31013101
if(adjust) {
31023102
if(hideOverflow) t.style('opacity', 0); // hidden
3103+
/*
31033104
else if(pushOverflow) {
31043105
if(adjust.indexOf('left') !== -1) t.attr('text-anchor', 'start');
31053106
if(adjust.indexOf('right') !== -1) t.attr('text-anchor', 'end');
3107+
// more TODO: https://github.com/plotly/plotly.js/issues/3292
31063108
}
3109+
*/
31073110
} else {
31083111
t.style('opacity', 1); // visible
31093112

src/plots/cartesian/layout_attributes.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -499,8 +499,8 @@ module.exports = {
499499
'allow',
500500
'hide past div',
501501
'hide past domain',
502-
'push to div',
503-
'push to domain'
502+
// 'push to div',
503+
// 'push to domain'
504504
],
505505
editType: 'calc',
506506
description: [

0 commit comments

Comments
 (0)