Skip to content

Commit 800971f

Browse files
committed
Minor cleanup for PR review
1 parent 7d4b482 commit 800971f

File tree

5 files changed

+3
-26
lines changed

5 files changed

+3
-26
lines changed

src/components/drawing/index.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ var makeBubbleSizeFn = require('../../traces/scatter/make_bubble_size_func');
2424

2525
var drawing = module.exports = {};
2626

27+
drawing.measureText = require('./measure_text');
28+
2729
// -----------------------------------------------------
2830
// styling functions for plot elements
2931
// -----------------------------------------------------

src/traces/carpet/axis_defaults.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ module.exports = function handleAxisDefaults(containerIn, containerOut, options)
4545
return Lib.coerce(containerIn, containerOut, attributes, attr, dflt);
4646
}
4747

48-
// I don't know what this does:
4948
function coerce2(attr, dflt) {
5049
return Lib.coerce2(containerIn, containerOut, attributes, attr, dflt);
5150
}

src/traces/carpet/measure_text.js

Lines changed: 0 additions & 22 deletions
This file was deleted.

src/traces/carpet/plot.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ var Drawing = require('../../components/drawing');
1414
var map1dArray = require('./map_1d_array');
1515
var makepath = require('./makepath');
1616
var orientText = require('./orient_text');
17-
var measureText = require('./measure_text');
1817

1918
module.exports = function plot(gd, plotinfo, cdcarpet) {
2019
for(var i = 0; i < cdcarpet.length; i++) {
@@ -153,7 +152,7 @@ function drawAxisLabels(tester, xaxis, yaxis, trace, t, layer, labels, labelClas
153152
orientation = orientText(trace, xaxis, yaxis, label.xy, [Math.cos(angle), Math.sin(angle)]);
154153
}
155154
var direction = (label.endAnchor ? -1 : 1) * orientation.flip;
156-
var bbox = measureText(tester, label.text, label.font);
155+
var bbox = Drawing.measureText(tester, label.text, label.font);
157156

158157
d3.select(this)
159158
.attr('text-anchor', direction > 0 ? 'start' : 'end')

src/traces/contourcarpet/style.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ module.exports = function style(gd) {
4040
.call(Drawing.lineGroupStyle,
4141
line.width,
4242
line.color,
43-
// contours.coloring === 'lines' ? colorMap(start + i * cs) : line.color,
4443
line.dash);
4544
});
4645

0 commit comments

Comments
 (0)