Skip to content

Commit 79dcbc3

Browse files
committed
Minor: var rename
1 parent a5dad2a commit 79dcbc3

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/transforms/groupby.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ function transformOne(trace, state, attributeSet) {
112112

113113
var style = opts.style || {};
114114

115-
var topLevelAttributes = attributeSet
115+
var arrayAttributes = attributeSet
116116
.filter(function(array) {return Array.isArray(getDeepProp(trace, array));});
117117

118118
var initializeArray = function(newTrace, a) {
@@ -131,12 +131,12 @@ function transformOne(trace, state, attributeSet) {
131131
// maybe we could abstract this out
132132
var newTrace = newData[i] = Lib.extendDeep({}, trace);
133133

134-
topLevelAttributes.forEach(initializeArray.bind(null, newTrace));
134+
arrayAttributes.forEach(initializeArray.bind(null, newTrace));
135135

136136
for(var j = 0; j < len; j++) {
137137
if(groups[j] !== groupName) continue;
138138

139-
topLevelAttributes.forEach(pasteArray.bind(0, newTrace, trace, j));
139+
arrayAttributes.forEach(pasteArray.bind(0, newTrace, trace, j));
140140
}
141141

142142
newTrace.name = groupName;

test/jasmine/tests/transform_groupby_test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -532,7 +532,7 @@ describe('groupby', function() {
532532
describe('passes with no `groups`', function() {
533533
'use strict';
534534

535-
afterEach(destroyGraphDiv);
535+
//afterEach(destroyGraphDiv);
536536

537537
var mockData = [{
538538
mode: 'markers+lines',
@@ -547,7 +547,7 @@ describe('groupby', function() {
547547
}]
548548
}];
549549

550-
it('passes', function(done) {
550+
fit('passes', function(done) {
551551
var data = Lib.extendDeep([], mockData);
552552

553553
var gd = createGraphDiv();

0 commit comments

Comments
 (0)