Skip to content

Commit 789e7e3

Browse files
committed
avoid extra second step when not needed also optimize for performance
1 parent eae05f2 commit 789e7e3

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

src/lib/increment.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,14 @@ module.exports = function incrementNumeric(x, delta) {
2525
// Note 2:
2626
// now we may also consider rounding to cover few more edge cases
2727
// e.g. 0.3 * 3 = 0.8999999999999999
28-
var lenDt = String(delta).length;
29-
var lenX0 = String(x).length;
3028
var lenX1 = String(newX).length;
29+
if(lenX1 > 16) {
30+
var lenDt = String(delta).length;
31+
var lenX0 = String(x).length;
3132

32-
if(lenX1 >= lenX0 + lenDt) { // likely a rounding error!
33-
newX = +parseFloat(newX).toPrecision(12);
33+
if(lenX1 >= lenX0 + lenDt) { // likely a rounding error!
34+
newX = +parseFloat(newX).toPrecision(12);
35+
}
3436
}
3537

3638
return newX;

0 commit comments

Comments
 (0)