Skip to content

Commit 71fa112

Browse files
committed
remove plotSchema change from before we decided to refactor finance to real traces
1 parent 82677ac commit 71fa112

File tree

1 file changed

+3
-18
lines changed

1 file changed

+3
-18
lines changed

src/plot_api/plot_schema.js

Lines changed: 3 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -252,12 +252,11 @@ exports.findArrayAttributes = function(trace) {
252252
exports.getTraceValObject = function(trace, parts) {
253253
var head = parts[0];
254254
var i = 1; // index to start recursing from
255-
var transforms = trace.transforms;
256-
if(!Array.isArray(transforms) || !transforms.length) transforms = false;
257255
var moduleAttrs, valObject;
258256

259257
if(head === 'transforms') {
260-
if(!transforms) return false;
258+
var transforms = trace.transforms;
259+
if(!Array.isArray(transforms) || !transforms.length) return false;
261260
var tNum = parts[1];
262261
if(!isIndex(tNum) || tNum >= transforms.length) {
263262
return false;
@@ -287,22 +286,8 @@ exports.getTraceValObject = function(trace, parts) {
287286
}
288287
}
289288

290-
// next look in the global attributes
289+
// finally look in the global attributes
291290
if(!valObject) valObject = baseAttributes[head];
292-
293-
// finally check if we have a transform matching the original trace type
294-
if(!valObject && transforms) {
295-
var inputType = trace._input.type;
296-
if(inputType && inputType !== trace.type) {
297-
for(var j = 0; j < transforms.length; j++) {
298-
if(transforms[j].type === inputType) {
299-
moduleAttrs = ((Registry.modules[inputType] || {})._module || {}).attributes;
300-
valObject = moduleAttrs && moduleAttrs[head];
301-
if(valObject) break;
302-
}
303-
}
304-
}
305-
}
306291
}
307292

308293
return recurseIntoValObject(valObject, parts, i);

0 commit comments

Comments
 (0)