Skip to content

Commit 6dfd319

Browse files
committed
GUPified filterbar styling which used to go a direct route
1 parent b477753 commit 6dfd319

File tree

1 file changed

+27
-26
lines changed

1 file changed

+27
-26
lines changed

src/traces/parcoords/parcoords.js

Lines changed: 27 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -131,38 +131,38 @@ module.exports = function(root, styledData, layout, callbacks) {
131131
var overdrag = 40;
132132
var legendWidth = 80;
133133

134-
function model(styledData) {
134+
function model(d) {
135135

136-
var data = styledData.dimensions;
136+
var data = d.dimensions;
137137

138-
var canvasPixelRatio = styledData.lines.pixelratio;
139-
var lines = Lib.extendDeep(styledData.lines, {
140-
color: styledData.line.color.map(domainToUnitScale(styledData.line.color)),
138+
var canvasPixelRatio = d.lines.pixelratio;
139+
var lines = Lib.extendDeep(d.lines, {
140+
color: d.line.color.map(domainToUnitScale(d.line.color)),
141141
canvasOverdrag: overdrag * canvasPixelRatio
142142
});
143143

144-
var layoutWidth = layout.width * (styledData.domain.x[1] - styledData.domain.x[0]);
145-
var layoutHeight = layout.height * (styledData.domain.y[1] - styledData.domain.y[0]);
144+
var layoutWidth = layout.width * (d.domain.x[1] - d.domain.x[0]);
145+
var layoutHeight = layout.height * (d.domain.y[1] - d.domain.y[0]);
146146

147-
var padding = styledData.padding || 80;
148-
var translateX = (styledData.domain.x[0] || 0) * layout.width;
149-
var translateY = (styledData.domain.y[0] || 0) * layout.height;
147+
var padding = d.padding || 80;
148+
var translateX = (d.domain.x[0] || 0) * layout.width;
149+
var translateY = (d.domain.y[0] || 0) * layout.height;
150150
var width = layoutWidth - 2 * padding - legendWidth; // leavig room for the colorbar
151151
var height = layoutHeight - 2 * padding;
152152

153153
var canvasWidth = width * canvasPixelRatio + 2 * lines.canvasOverdrag;
154154
var canvasHeight = height * canvasPixelRatio;
155155

156-
var resizeHeight = styledData.filterbar.handleheight;
157-
var brushVisibleWidth = styledData.filterbar.width;
158-
var brushCaptureWidth = styledData.filterbar.capturewidth || Math.min(32, brushVisibleWidth + 16);
156+
var resizeHeight = d.filterbar.handleheight;
157+
var brushVisibleWidth = d.filterbar.width;
158+
var brushCaptureWidth = d.filterbar.capturewidth || Math.min(32, brushVisibleWidth + 16);
159159

160160
return [
161161
{
162162
key: Math.random(),
163163
dimensions: data,
164-
tickDistance: styledData.tickdistance,
165-
unitToColor: styledData.unitToColor,
164+
tickDistance: d.tickdistance,
165+
unitToColor: d.unitToColor,
166166
lines: lines,
167167
translateX: translateX,
168168
translateY: translateY,
@@ -174,7 +174,8 @@ module.exports = function(root, styledData, layout, callbacks) {
174174
brushVisibleWidth: brushVisibleWidth,
175175
brushCaptureWidth: brushCaptureWidth,
176176
resizeHeight: resizeHeight,
177-
canvasPixelRatio: canvasPixelRatio
177+
canvasPixelRatio: canvasPixelRatio,
178+
filterBar: d.filterbar
178179
}
179180
];
180181
}
@@ -206,11 +207,11 @@ module.exports = function(root, styledData, layout, callbacks) {
206207
.attr('width', function(d) {return d.model.brushVisibleWidth})
207208
.attr('height', function(d) {return d.model.height})
208209
.attr('x', function(d) {return d.model.brushVisibleWidth / 2;})
209-
.attr('fill', styledData.filterbar.fillcolor)
210-
.attr('fill-opacity', styledData.filterbar.fillopacity)
211-
.attr('stroke', styledData.filterbar.strokecolor)
212-
.attr('stroke-opacity', styledData.filterbar.strokeopacity)
213-
.attr('stroke-width', styledData.filterbar.strokewidth);
210+
.attr('fill', function(d) {return d.model.filterBar.fillcolor;})
211+
.attr('fill-opacity', function(d) {return d.model.filterBar.fillopacity;})
212+
.attr('stroke', function(d) {return d.model.filterBar.strokecolor;})
213+
.attr('stroke-opacity', function(d) {return d.model.filterBar.strokeopacity;})
214+
.attr('stroke-width', function(d) {return d.model.filterBar.strokewidth;});
214215
}
215216

216217
var parcoordsModel = d3.select(root).selectAll('.parcoordsModel')
@@ -414,7 +415,7 @@ module.exports = function(root, styledData, layout, callbacks) {
414415
axisTitle.enter()
415416
.append('text')
416417
.classed('axisTitle', true)
417-
.attr('transform', 'translate(0,' + -(styledData.filterbar.handleheight + 20) + ')')
418+
.attr('transform', function(d) {return 'translate(0,' + -(d.model.filterBar.handleheight + 20) + ')';})
418419
.text(function(d) {return d.label;})
419420
.attr('text-anchor', 'middle')
420421
.style('font-family', 'sans-serif')
@@ -435,7 +436,7 @@ module.exports = function(root, styledData, layout, callbacks) {
435436
axisExtentTop.enter()
436437
.append('g')
437438
.classed('axisExtentTop', true)
438-
.attr('transform', 'translate(' + 0 + ',' + -(styledData.filterbar.handleheight - 2) + ')');
439+
.attr('transform', function(d) {return 'translate(' + 0 + ',' + -(d.model.filterBar.handleheight - 2) + ')';});
439440

440441
var axisExtentTopText = axisExtentTop.selectAll('.axisExtentTopText')
441442
.data(repeat, keyFun);
@@ -457,7 +458,7 @@ module.exports = function(root, styledData, layout, callbacks) {
457458
axisExtentBottom.enter()
458459
.append('g')
459460
.classed('axisExtentBottom', true)
460-
.attr('transform', function(d) {return 'translate(' + 0 + ',' + (d.model.height + styledData.filterbar.handleheight - 2) + ')';});
461+
.attr('transform', function(d) {return 'translate(' + 0 + ',' + (d.model.height + d.model.filterBar.handleheight - 2) + ')';});
461462

462463
var axisExtentBottomText = axisExtentBottom.selectAll('.axisExtentBottomText')
463464
.data(repeat, keyFun);
@@ -510,11 +511,11 @@ module.exports = function(root, styledData, layout, callbacks) {
510511

511512
axisBrushEnter
512513
.selectAll('.resize.n rect')
513-
.attr('y', function() {var d = this.parentElement.parentElement.__data__; return -d.model.resizeHeight + styledData.filterbar.handleoverlap;});
514+
.attr('y', function() {var d = this.parentElement.parentElement.__data__; return -d.model.resizeHeight + d.model.filterBar.handleoverlap;});
514515

515516
axisBrushEnter
516517
.selectAll('.resize.s rect')
517-
.attr('y', -styledData.filterbar.handleoverlap);
518+
.attr('y', function() {var d = this.parentElement.parentElement.__data__; return -d.model.filterBar.handleoverlap;});
518519

519520
var justStarted = false;
520521
var contextShown = false;

0 commit comments

Comments
 (0)