Skip to content

Commit 6da70ac

Browse files
committed
test: adapt supplyTraceDefaults tests for _transformModules
- which is now assumed to be in fullLayout
1 parent dda7110 commit 6da70ac

File tree

2 files changed

+12
-5
lines changed

2 files changed

+12
-5
lines changed

test/jasmine/tests/transform_filter_test.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ var assertStyle = require('../assets/assert_style');
1111

1212
describe('filter transforms defaults:', function() {
1313

14+
var fullLayout = { _transformModules: [] };
15+
1416
var traceIn, traceOut;
1517

1618
it('supplyTraceDefaults should coerce all attributes', function() {
@@ -22,7 +24,7 @@ describe('filter transforms defaults:', function() {
2224
}]
2325
};
2426

25-
traceOut = Plots.supplyTraceDefaults(traceIn, 0, {});
27+
traceOut = Plots.supplyTraceDefaults(traceIn, 0, fullLayout);
2628

2729
expect(traceOut.transforms).toEqual([{
2830
type: 'filter',
@@ -44,7 +46,7 @@ describe('filter transforms defaults:', function() {
4446
}]
4547
};
4648

47-
traceOut = Plots.supplyTraceDefaults(traceIn, 0, {});
49+
traceOut = Plots.supplyTraceDefaults(traceIn, 0, fullLayout);
4850

4951
expect(traceOut.transforms).toEqual([{
5052
type: 'filter',
@@ -70,7 +72,7 @@ describe('filter transforms defaults:', function() {
7072
}]
7173
};
7274

73-
traceOut = Plots.supplyTraceDefaults(traceIn, 0, {});
75+
traceOut = Plots.supplyTraceDefaults(traceIn, 0, fullLayout);
7476

7577
expect(traceOut.transforms[0].target).toEqual('x');
7678
expect(traceOut.transforms[1].target).toEqual('x');

test/jasmine/tests/transform_multi_test.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ var assertStyle = require('../assets/assert_style');
1313
describe('general transforms:', function() {
1414
'use strict';
1515

16+
var fullLayout = { _transformModules: [] };
17+
1618
var traceIn, traceOut;
1719

1820
it('supplyTraceDefaults should supply the transform defaults', function() {
@@ -21,7 +23,7 @@ describe('general transforms:', function() {
2123
transforms: [{ type: 'filter' }]
2224
};
2325

24-
traceOut = Plots.supplyTraceDefaults(traceIn, 0, {});
26+
traceOut = Plots.supplyTraceDefaults(traceIn, 0, fullLayout);
2527

2628
expect(traceOut.transforms).toEqual([{
2729
type: 'filter',
@@ -39,7 +41,7 @@ describe('general transforms:', function() {
3941
transforms: [{ type: 'invalid' }]
4042
};
4143

42-
traceOut = Plots.supplyTraceDefaults(traceIn, 0, {});
44+
traceOut = Plots.supplyTraceDefaults(traceIn, 0, fullLayout);
4345

4446
expect(traceOut.y).toBe(traceIn.y);
4547
});
@@ -56,6 +58,7 @@ describe('general transforms:', function() {
5658
};
5759

5860
var layout = {
61+
_transformModules: [],
5962
_globalTransforms: [{
6063
type: 'filter'
6164
}]
@@ -80,6 +83,8 @@ describe('general transforms:', function() {
8083
target: 'x',
8184
_module: Filter
8285
}, '- trace second');
86+
87+
expect(layout._transformModules).toEqual([Filter]);
8388
});
8489

8590
it('supplyDataDefaults should apply the transform while', function() {

0 commit comments

Comments
 (0)