Skip to content

Commit 6b74fbe

Browse files
committed
🔪 TODOs we've done
1 parent a7e2f32 commit 6b74fbe

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

src/traces/histogram/bin_label_vals.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@ module.exports = function getBinSpanLabelRound(leftGap, rightGap, binEdges, pa,
7878
var roundedV = digit * Math.round(v / digit);
7979
// if we rounded down and we could round up and still be < leftGap
8080
// (or what leftGap values round to), do that
81-
// TODO: is the `digit / 2` correct or is that too much leeway?
8281
if(roundedV + (digit / 10) < v && roundedV + (digit * 0.9) < v + leftGap) {
8382
roundedV += digit;
8483
}
@@ -130,7 +129,6 @@ function biggestGuaranteedDigitChanged(dv, isDate) {
130129
if(isDate && dv > oneSec) {
131130
// this is supposed to be the biggest *guaranteed* change
132131
// so compare to the longest month and year across any calendar,
133-
// (TODO: does 1.1 do that? I think so...)
134132
// and we'll iterate back up later
135133
// note: does not support rounding larger than one year. We could add
136134
// that if anyone wants it, but seems unusual and not strictly necessary.

0 commit comments

Comments
 (0)