Skip to content

Commit 697db13

Browse files
committed
refactor functions
1 parent 257b32c commit 697db13

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

src/traces/scattermapbox/plot.js

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,14 @@ proto.update = function update(calcTrace) {
128128
}
129129
}
130130

131+
function remove() {
132+
if(hadCluster) removeCluster(); else removeNonCluster();
133+
}
134+
135+
function add() {
136+
if(hasCluster) addCluster(); else addNonCluster();
137+
}
138+
131139
function repaint() {
132140
var order = hasCluster ? ORDER.cluster : ORDER.nonCluster;
133141
for(var i = 0; i < order.length; i++) {
@@ -150,12 +158,12 @@ proto.update = function update(calcTrace) {
150158
var isHidden = trace.visible !== true;
151159

152160
if(isHidden && !wasHidden) {
153-
if(hadCluster) removeCluster(); else removeNonCluster();
161+
remove();
154162
} else if(!isHidden && wasHidden) {
155-
if(hasCluster) addCluster(); else addNonCluster();
163+
add();
156164
} else if(hadCluster !== hasCluster) {
157-
if(hadCluster) removeCluster(); else removeNonCluster();
158-
if(hasCluster) addCluster(); else addNonCluster();
165+
remove();
166+
add();
159167
} else {
160168
repaint();
161169
}

0 commit comments

Comments
 (0)