Skip to content

Commit 64d2bcd

Browse files
committed
Remove unneeded inputTraceCount parameter
1 parent 7298a0c commit 64d2bcd

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

src/plots/plots.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -798,7 +798,7 @@ plots.supplyDataDefaults = function(dataIn, dataOut, layout, fullLayout) {
798798

799799
for(i = 0; i < dataIn.length; i++) {
800800
trace = dataIn[i];
801-
fullTrace = plots.supplyTraceDefaults(trace, cnt, fullLayout, i, dataIn.length);
801+
fullTrace = plots.supplyTraceDefaults(trace, cnt, fullLayout, i);
802802

803803
fullTrace.index = i;
804804
fullTrace._input = trace;
@@ -809,7 +809,7 @@ plots.supplyDataDefaults = function(dataIn, dataOut, layout, fullLayout) {
809809

810810
for(var j = 0; j < expandedTraces.length; j++) {
811811
var expandedTrace = expandedTraces[j];
812-
var fullExpandedTrace = plots.supplyTraceDefaults(expandedTrace, cnt, fullLayout, i, dataIn.length);
812+
var fullExpandedTrace = plots.supplyTraceDefaults(expandedTrace, cnt, fullLayout, i);
813813

814814
// The group key gets cleared. If set, pass it forward
815815
if(expandedTrace._group) {
@@ -945,7 +945,7 @@ plots.supplyFrameDefaults = function(frameIn) {
945945
return frameOut;
946946
};
947947

948-
plots.supplyTraceDefaults = function(traceIn, traceOutIndex, layout, traceInIndex, inputTraceCount) {
948+
plots.supplyTraceDefaults = function(traceIn, traceOutIndex, layout, traceInIndex) {
949949
var traceOut = {},
950950
defaultColor = Color.defaults[traceOutIndex % Color.defaults.length];
951951

@@ -1018,13 +1018,13 @@ plots.supplyTraceDefaults = function(traceIn, traceOutIndex, layout, traceInInde
10181018
traceOut.visible = !!traceOut.visible;
10191019
}
10201020

1021-
plots.supplyTransformDefaults(traceIn, traceOut, layout, inputTraceCount);
1021+
plots.supplyTransformDefaults(traceIn, traceOut, layout);
10221022
}
10231023

10241024
return traceOut;
10251025
};
10261026

1027-
plots.supplyTransformDefaults = function(traceIn, traceOut, layout, inputTraceCount) {
1027+
plots.supplyTransformDefaults = function(traceIn, traceOut, layout) {
10281028
var globalTransforms = layout._globalTransforms || [];
10291029
var transformModules = layout._transformModules || [];
10301030

@@ -1043,7 +1043,7 @@ plots.supplyTransformDefaults = function(traceIn, traceOut, layout, inputTraceCo
10431043
if(!_module) Lib.warn('Unrecognized transform type ' + type + '.');
10441044

10451045
if(_module && _module.supplyDefaults) {
1046-
transformOut = _module.supplyDefaults(transformIn, traceOut, layout, traceIn, inputTraceCount);
1046+
transformOut = _module.supplyDefaults(transformIn, traceOut, layout, traceIn);
10471047
transformOut.type = type;
10481048
transformOut._module = _module;
10491049

src/transforms/groupby.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ exports.attributes = {
100100
* @return {object} transformOut
101101
* copy of transformIn that contains attribute defaults
102102
*/
103-
exports.supplyDefaults = function(transformIn, traceOut, layout, traceIn, inputTraceCount) {
103+
exports.supplyDefaults = function(transformIn, traceOut, layout, traceIn) {
104104
var i;
105105
var transformOut = {};
106106

@@ -113,7 +113,7 @@ exports.supplyDefaults = function(transformIn, traceOut, layout, traceIn, inputT
113113
if(!enabled) return transformOut;
114114

115115
coerce('groups');
116-
coerce('nameformat', inputTraceCount > 1 ? '%g (%t)' : '%g');
116+
coerce('nameformat', layout._dataLength > 1 ? '%g (%t)' : '%g');
117117

118118
var nameFormatIn = transformIn.groupnames;
119119
var nameFormatOut = transformOut.groupnames = [];

0 commit comments

Comments
 (0)