Skip to content

Commit 5d586dd

Browse files
Use dicts in the function calls with many parameters
1 parent 472c135 commit 5d586dd

File tree

1 file changed

+39
-8
lines changed

1 file changed

+39
-8
lines changed

test/jasmine/assets/domain_ref/components.js

Lines changed: 39 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -594,8 +594,15 @@ function testShapeCombo(combo, assert, gd) {
594594
var yAxNum = axispair[1].substr(1);
595595
return Plotly.newPlot(gd, Lib.extendDeep({}, testMock))
596596
.then(function(gd) {
597-
return shapeTest(gd, xAxNum, xaxisType, xaroPos, yAxNum, yaxisType, yaroPos,
598-
shapeType);
597+
return shapeTest(gd,
598+
{xAxNum: xAxNum,
599+
xaxisType: xaxisType,
600+
xaroPos: xaroPos,
601+
yAxNum: yAxNum,
602+
yaxisType: yaxisType,
603+
yaroPos: yaroPos,
604+
aroType: shapeType,
605+
});
599606
}).then(function(testRet) {
600607
assert(testRet);
601608
});
@@ -644,10 +651,21 @@ function testImageCombo(combo, assert, gd) {
644651
var yref = makeAxRef(yid, aroposy.ref);
645652
return Plotly.newPlot(gd, Lib.extendDeep({}, testMock))
646653
.then(function(gd) {
647-
return imageTest(gd, {}, axistypex, axistypey,
648-
aroposx.value[0], aroposy.value[0], aroposx.size,
649-
aroposy.size,
650-
xanchor, yanchor, xref, yref, xid, yid);
654+
return imageTest(gd, {},
655+
{
656+
xaxtype: axistypex,
657+
yaxtype: axistypey,
658+
x: aroposx.value[0],
659+
y: aroposy.value[0],
660+
sizex: aroposx.size,
661+
sizey: aroposy.size,
662+
xanchor: xanchor,
663+
yanchor: yanchor,
664+
xref: xref,
665+
yref: yref,
666+
xid: xid,
667+
yid: yid,
668+
});
651669
}).then(function(testRet) {
652670
assert(testRet);
653671
});
@@ -698,8 +716,21 @@ function testAnnotationCombo(combo, assert, gd) {
698716
var ay = ayref === 'pixel' ? aroposy.pixel : aroposy.value[1];
699717
return Plotly.newPlot(gd, Lib.extendDeep({}, testMock))
700718
.then(function(gd) {
701-
return annotationTest(gd, {}, x0, y0, ax, ay, xref, yref, axref,
702-
ayref, axistypex, axistypey, xid, yid);
719+
return annotationTest(gd, {},
720+
{
721+
x0: x0,
722+
y0: y0,
723+
ax: ax,
724+
ay: ay,
725+
xref: xref,
726+
yref: yref,
727+
axref: axref,
728+
ayref: ayref,
729+
axistypex: axistypex,
730+
axistypey: axistypey,
731+
xid: xid,
732+
yid: yid,
733+
});
703734
}).then(function(testRet) {
704735
assert(testRet);
705736
});

0 commit comments

Comments
 (0)