Skip to content

Commit 5a9f0cc

Browse files
committed
bump dev deps
- update circluar dep test-syntax check for madge v1
1 parent 65e1ab3 commit 5a9f0cc

File tree

2 files changed

+16
-15
lines changed

2 files changed

+16
-15
lines changed

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -96,9 +96,9 @@
9696
"browserify": "^13.0.0",
9797
"browserify-transform-tools": "^1.5.1",
9898
"deep-equal": "^1.0.1",
99-
"ecstatic": "^1.4.0",
99+
"ecstatic": "^2.1.0",
100100
"eslint": "^3.5.0",
101-
"falafel": "^1.2.0",
101+
"falafel": "^2.0.0",
102102
"fs-extra": "^0.30.0",
103103
"fuse.js": "^2.2.0",
104104
"glob": "^7.0.0",
@@ -107,11 +107,11 @@
107107
"jasmine-core": "^2.4.1",
108108
"karma": "^1.1.0",
109109
"karma-browserify": "^5.0.1",
110-
"karma-chrome-launcher": "^1.0.1",
110+
"karma-chrome-launcher": "^2.0.0",
111111
"karma-coverage": "^1.0.0",
112112
"karma-firefox-launcher": "^1.0.0",
113113
"karma-jasmine": "^1.0.2",
114-
"madge": "^0.6.0",
114+
"madge": "^1.4.3",
115115
"node-sass": "^3.4.1",
116116
"npm-link-check": "^1.1.0",
117117
"open": "0.0.5",

tasks/test_syntax.js

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -98,20 +98,21 @@ function assertFileNames() {
9898

9999
// check circular dependencies
100100
function assertCircularDeps() {
101-
var dependencyObject = madge(constants.pathToSrc);
102-
var circularDeps = dependencyObject.circular().getArray();
103-
var logs = [];
101+
madge(constants.pathToSrc).then(function(res) {
102+
var circularDeps = res.circular();
103+
var logs = [];
104104

105-
// as of v1.17.0 - 2016/09/08
106-
// see https://github.com/plotly/plotly.js/milestone/9
107-
// for more details
108-
var MAX_ALLOWED_CIRCULAR_DEPS = 34;
105+
// as of v1.17.0 - 2016/09/08
106+
// see https://github.com/plotly/plotly.js/milestone/9
107+
// for more details
108+
var MAX_ALLOWED_CIRCULAR_DEPS = 34;
109109

110-
if(circularDeps.length > MAX_ALLOWED_CIRCULAR_DEPS) {
111-
logs.push('some new circular dependencies were added to src/');
112-
}
110+
if(circularDeps.length > MAX_ALLOWED_CIRCULAR_DEPS) {
111+
logs.push('some new circular dependencies were added to src/');
112+
}
113113

114-
log('circular dependencies', logs);
114+
log('circular dependencies', logs);
115+
});
115116
}
116117

117118
function combineGlobs(arr) {

0 commit comments

Comments
 (0)